➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2004-08-05 02:09 by davecole, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| socketpair.patch | davecole, 2004-08-05 02:09 | Adds socketpair function to socket module | ||
| socketpair-v2.patch | davecole, 2004-08-09 04:48 | Updated patch to include missing items | ||
| Messages (6) | |||
|---|---|---|---|
| msg46542 - (view) | Author: Dave Cole (davecole)  |
Date: 2004-08-05 02:09 | |
Adds a socketpair() function to the socketmodule.c. The function returns two socket objects. Contains some simple unit tests that check the return value from socketpair is actually two functioning sockets. Outstanding question is whether the family, type, proto arguments should be kwargs as per socket() function, or positional as per fromfd() function. If kwargs, then it is arguable that the fromfd() arguments should be changed (in another patch). |
|||
| msg46543 - (view) | Author: Martin v. Löwis (loewis) *  |
Date: 2004-08-06 07:10 | |
Logged In: YES
user_id=21627
The patch is fine, please apply. Make sure to
- add \versionadded{2.4} into the documentation
- add an entry to Misc/NEWS
|
|||
| msg46544 - (view) | Author: Dave Cole (davecole) |
Date: 2004-08-09 04:48 | |
Logged In: YES user_id=28658 Have addressed all of the issues with the v2 patch. Will commit this now. |
|||
| msg46545 - (view) | Author: Dave Cole (davecole) |
Date: 2004-08-09 04:53 | |
Logged In: YES user_id=28658 Commited the patch. |
|||
| msg46546 - (view) | Author: Martin v. Löwis (loewis) * |
Date: 2004-08-09 05:54 | |
Logged In: YES user_id=21627 In the future, please add the version numbers of the changed files into the SF patch/bug report. |
|||
| msg46547 - (view) | Author: Dave Cole (davecole) |
Date: 2004-08-09 06:13 | |
Logged In: YES user_id=28658 Sorry about that. Here they are: configure.in; new revision 1.464 pyconfig.h.in; new revision 1.102 Doc/lib/libsocket.tex; new revision 1.85 (fix in 1.86) Lib/socket.py; new revision 1.45 Lib/test/test_socket.py; new revision 1.73 Misc/NEWS; new revision 1.1081 Modules/socketmodule.c; new revision 1.299 (I looked for an example in on eof your patch commits - did not have any revisions... had to look at tim_one for example :-). |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:06 | admin | set | github: 40690 |
| 2004-08-05 02:09:10 | davecole | create | |