➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: replacing rfc822.formatdate
Type: Stage:
Components: Library (Lib) Versions: Python 2.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: anthonybaxter Nosy List: anthonybaxter, barry, ncoghlan
Priority: normal Keywords: patch

Created on 2004-08-09 09:31 by anthonybaxter, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
formatdate.diff anthonybaxter, 2004-08-09 09:31 removing rfc822.formatdate usage.diff
Messages (4)
msg46591 - (view) Author: Anthony Baxter (anthonybaxter) (Python triager) Date: 2004-08-09 09:31 
If we're going to deprecate rfc822, we should stop
using it.
The following patch makes urllib and urllib2 stop using it
for date strings. Unfortunately HTTP insists on the "GMT" 
notation for the timezone, not "-0000"[1], so
email.Utils.formatdate
grew a new flag "asciigmt". 

Assigning to Barry, as email is his baby.


[1]
http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.3.1
msg46592 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2004-08-11 06:07 
Logged In: YES 
user_id=1038590

I downloaded and applied this without any apparent problems.

(I got a failure of test_socketserver when running with
-unetwork, but I reverted the patch and confirmed that that
was not due to Anthony's patch)
msg46593 - (view) Author: Barry A. Warsaw (barry) * (Python committer) Date: 2004-10-08 20:48 
Logged In: YES 
user_id=12800

Please include a test case, and add a note to the
documentation that asciigmt is only consulted if the
localtime flag is true.  Also 'asciigmt' looks kind of funny
-- how about 'usegmt'?

Other than that +1
msg46594 - (view) Author: Anthony Baxter (anthonybaxter) (Python triager) Date: 2004-10-11 13:55 
Logged In: YES 
user_id=29957

Checked in, with Barry's changes.

Doc/lib/emailutil.tex 1.10
Lib/urllib.py 1.165
Lib/urllib2.py 1.77
Lib/email/Utils.py 1.28
Lib/email/test/test_email.py 1.64
History
Date User Action Args
2022-04-11 14:56:06adminsetgithub: 40722
2004-08-09 09:31:04anthonybaxtercreate