This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Cleanup Peepholer Output
Type: Stage:
Components: Interpreter Core Versions: Python 2.4
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: mwh, rhettinger
Priority: high Keywords: patch

Created on 2004-08-22 05:34 by rhettinger, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
peep2.diff rhettinger, 2004-08-22 22:18 Revised with better formatting and more tests.
Messages (4)
msg46755 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2004-08-22 05:34
Makes the peepholer output more compact, more readable,
and a bit faster.  Also saves a bit of space in pyc files.

* Uses NOPs instead of JMP+3 or JMP+2.
* Then, makes a pass to eliminate the NOPs (which
entails re-aligning the jump targets and linenotab).
* Add a transform to get rid of the unnecessary Return
Nones followed by another Return in the same block.
* Fixed the overflow test (codelen < 65000) to coerce
codelen to unsigned before the check.

Michael, I would appreciate it if you could give this a
second look just to make sure before I check it in.  I
would like it to go in well before the next alpha.  The
patch passes the test suite, runs all my own apps, and
has run on my machine for about a week with any issues.
If you don't have time to give it a once over, please
assign to Armin.
msg46756 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2004-08-22 22:18
Logged In: YES 
user_id=80475

Added a revision with better formatting and more tests.

This patch is open for whoever has time to look at it first.
msg46757 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2004-08-23 23:38
Logged In: YES 
user_id=80475

No reviewers responded to my emails.  Applying now so that
it gets exercised as much as possible before the next alpha
release.
msg46758 - (view) Author: Michael Hudson (mwh) (Python committer) Date: 2004-08-24 11:12
Logged In: YES 
user_id=6656

Raymond, for the future: it's pretty rare for me to read my
email at the weekend...
History
Date User Action Args
2022-04-11 14:56:06adminsetgithub: 40799
2004-08-22 05:34:15rhettingercreate