➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: add missing __all__ to pickletools.py
Type: Stage:
Components: Library (Lib) Versions: Python 2.3
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: quiver, tim.peters
Priority: normal Keywords: patch

Created on 2004-11-06 23:03 by quiver, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
pickletools.diff quiver, 2004-11-06 23:03 patch against CVS HEAD
Messages (2)
msg47217 - (view) Author: George Yoshida (quiver) (Python committer) Date: 2004-11-06 23:03 
pickletools.py module has its own document and only 
two functions are documented there for external use.
However, __all__ is not defined in pickletools.py. :

  $ python -c 'from pickletools import *;print len(globals
())'
  60

Setting the __all__ variable seems reasonable to me.
msg47218 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2004-11-06 23:47 
Logged In: YES 
user_id=31435

Yup, that's a good idea.  I didn't realize this was a patch at 
first, so I just did it.  It's a lot like your patch <wink>.

Lib/pickletools.py 1.28
Lib/test/test___all__.py 1.41
Misc/NEWS 1.1184
History
Date User Action Args
2022-04-11 14:56:07adminsetgithub: 41130
2004-11-06 23:03:42quivercreate