This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Decimal interaction with __rop__
Type: Stage:
Components: Library (Lib) Versions: Python 2.4
process
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: facundobatista Nosy List: facundobatista, rhettinger
Priority: normal Keywords: patch

Created on 2005-03-19 19:10 by facundobatista, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
rop_diff.txt facundobatista, 2005-03-19 19:10 diff file
Messages (3)
msg47998 - (view) Author: Facundo Batista (facundobatista) * (Python committer) Date: 2005-03-19 19:10
Ok, this is the result of last discussion in python-dev.

I changed _convert_other() to make it return
NotImplemented, and check in every place where it's
called to pass back the NotImplemented (something
similar suggested Michael Hudson in the discussion: he
passed back "other", but I think is cleaner just to
pass the signal, and let the architecture to do
whatever it should).

The tests runs ok, seeing a +1.8% in test_decimal time.

I'm sending this to you, because I...

- Don't get to understand from the discussion if this
is something that should be fixed at this level or at
another.

- Don't really know if this solution is as clean as it
seems.

Thanks! 

.    Facundo

msg47999 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2005-04-10 16:44
Logged In: YES 
user_id=80475

I had checked in my own patch for the rop issue.  Please cross-
check these two patches to see if one did something that the 
other had not.
msg48000 - (view) Author: Facundo Batista (facundobatista) * (Python committer) Date: 2005-05-07 23:05
Logged In: YES 
user_id=752496

Yours is slightly better, :).
History
Date User Action Args
2022-04-11 14:56:10adminsetgithub: 41719
2005-03-19 19:10:15facundobatistacreate