➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: poorly named variable in urllib2.py
Type: Stage:
Components: Library (Lib) Versions: Python 2.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: georg.brandl Nosy List: georg.brandl, georg.brandl, jjlee, roysmith
Priority: normal Keywords:

Created on 2005-04-03 15:26 by roysmith, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (3)
msg24872 - (view) Author: Roy Smith (roysmith) Date: 2005-04-03 15:26 
This is kind of trivial, but in urllib2.OpenerDirector.__init__, the local 
variable "server_version" is poorly named.  The name makes it 
sound like it's the version of the HTTP (or whatever) server we're 
talking to.  How about client_version or library_version or 
module_version?
msg24873 - (view) Author: John J Lee (jjlee) Date: 2005-05-19 19:10 
Logged In: YES 
user_id=261020

My, you're picky. ;-)

Yes, that does seem a poor name, +1 on changing it to
client_version.
msg24874 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2005-06-26 22:01 
Logged In: YES 
user_id=1188172

Fixed as of Lib/urllib2.py r1.82.
History
Date User Action Args
2022-04-11 14:56:10adminsetgithub: 41796
2005-04-03 15:26:51roysmithcreate