This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Complex commented
Type: Stage:
Components: Demos and Tools Versions:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: grubert, loewis, rhettinger
Priority: normal Keywords: patch

Created on 2005-04-06 08:37 by grubert, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
Demo-Complex.patch grubert, 2005-04-06 08:37 patch to Demo/classes/Complex.py
Complex.patch grubert, 2005-04-08 15:39 second patch
Messages (5)
msg48161 - (view) Author: engelbert gruber (grubert) * Date: 2005-04-06 08:37
i ran pychecker over Complex.py

1. "i is not defined": in the constructor, but __init__ looks 
   strange to me, so i only made a comment and changed
   the second if to elif.
2. "sys" is not defined: in __hash__, moved import sys to the top.
3. "re" and "im" attributes dont exist: probably a pychecker
   problem, but i did add a comment.


msg48162 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2005-04-07 23:00
Logged In: YES 
user_id=21627

Please review __init__ with the understanding that it is
meant to compute

  re + im*1j

even provided re or im could be complex. So "i" should
probably be "im", and both re and im can be complex.
msg48163 - (view) Author: engelbert gruber (grubert) * Date: 2005-04-08 15:39
Logged In: YES 
user_id=147070

a liitle greedy arnt we :-)

i tried harder, hope it will be more like it
msg48164 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2005-04-08 18:29
Logged In: YES 
user_id=80475

Sure, that is, if high standards of quality can be called
greed ;-)
msg48165 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2005-04-09 10:53
Logged In: YES 
user_id=21627

Thanks for the patch, committed as Complex.py  1.8, NEWS 1.1284
History
Date User Action Args
2022-04-11 14:56:10adminsetgithub: 41810
2005-04-06 08:37:44grubertcreate