This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: [AST] Patch [ 1190012 ] should've checked for SyntaxWarnings
Type: Stage:
Components: Interpreter Core Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: brett.cannon Nosy List: brett.cannon, logistix, nascheme
Priority: normal Keywords:

Created on 2005-05-04 23:13 by logistix, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (4)
msg25227 - (view) Author: Grant Olson (logistix) Date: 2005-05-04 23:13
"[ 1190012 ] don't assume all errors are syntax errors"
should also check allow SyntaxWarnings to pass.  This
is a one-line fix at around line 104 in
ast_error_finish in ast.c.

This causes the failure in test_warnings.py.

Brett,

If you really want a patch, I can get you one, but
right now my copy of ast.c is a little too far out of
sync to generate a clean patch.  The fix is pretty
trivial though.

Let me know.

-Grant

msg25228 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2005-05-06 20:01
Logged In: YES 
user_id=357491

I shouldn't need a patch, but it might be a little while
until I get to this.  I am down to the last couple of weeks
of the quarter and I am racing to get my masters thesis done
before I graduate.  Plus a quick recompile the other night
under gcc 4 led to a ton of errors for me (hoping it was
just a fluke; something about sem_init() ).
msg25229 - (view) Author: Neil Schemenauer (nascheme) * (Python committer) Date: 2005-06-18 18:05
Logged In: YES 
user_id=35752

I haven't dug to deep into this but test_warnings now
passes.  The ast.c ast_error_finish function doesn't seem to
have been changed.  I think test_warnings was failing for
some other reason.

It looks like SyntaxWarnings are not currently generated by
newcompile.c.  I'm leaving this issue open until that gets
fixed.  Probably a test should be added that actually causes
a SyntaxWarning to be generated by the compiler.
msg25230 - (view) Author: Neil Schemenauer (nascheme) * (Python committer) Date: 2005-10-12 00:55
Logged In: YES 
user_id=35752

SyntaxWarnings are now generated by the AST compiler and
test_warnings.py passes.
History
Date User Action Args
2022-04-11 14:56:11adminsetgithub: 41949
2005-05-04 23:13:13logistixcreate