➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Trivial typo in unicodedata._getcode
Type: Stage:
Components: None Versions:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: loewis Nosy List: dsuch, loewis, rhettinger
Priority: normal Keywords: patch

Created on 2005-06-02 22:00 by dsuch, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
ucd_getcode_typo.diff dsuch, 2005-06-02 22:02 Fixed typo in unicodedata._getcode
Messages (3)
msg48423 - (view) Author: Dariusz Suchojad (dsuch) Date: 2005-06-02 22:00 
Hi,
I think there's a typo in unicodedata module's _getcode
function.
Line 823 (today's CVS build) should be 

if (L != -1 && V != -1 && T != -1 && pos-name == namelen) {

not 

if (V != -1 && V != -1 && T != -1 && pos-name == namelen) {

as in attached patch.
msg48424 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2005-06-03 00:36 
Logged In: YES 
user_id=80475

Martin, I believe this is your code.
msg48425 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2005-09-18 08:19 
Logged In: YES 
user_id=21627

Thanks for the patch. Committed as

NEWS 1.1368
unicodedata.c 2.35
NEWS 1.1193.2.100
unicodedata.c 2.32.2.1
History
Date User Action Args
2022-04-11 14:56:11adminsetgithub: 42048
2005-06-02 22:00:54dsuchcreate