This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Zipfile fix create_system information
Type: Stage:
Components: None Versions:
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: georg.brandl, hendriktt, ronaldoussoren, sf-robot
Priority: normal Keywords: patch

Created on 2005-06-29 07:47 by hendriktt, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
zipfile_create_system.patch hendriktt, 2005-06-29 07:47 patch for create_system information
Messages (4)
msg48533 - (view) Author: Hendrik Muhs (hendriktt) Date: 2005-06-29 07:47
this patches corrects the create_system value for
created zipfiles with the zipfile module, which is
platform dependent (better: filesystem dependent). 
It fixes the following bug: if a zipfile is created
with Python on Unix and the files have executable flags
the file rights are correctly saved into the zipfile.
But when extracting the file with unzip (from Info-zip)
the filerights (executable flags) are not reassigned
correctly. This is due to the wrong create_system flag.

The patch is not the 100% correct way to do it, but it
is better as the situation now (completly ignore the
system and always set create_system to 0).

The right way to fix this would be to set the
create_system flag dependent on the platform and the
filesystem but I do not know how to do this.
msg48534 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2006-03-07 12:35
Logged In: YES 
user_id=580910

Could you check if the trunk is acceptable to you, and if so close this patch?

Patch 1412872 also sets create_system to another value on unix systems and 
was applied at 05 feb 2006.
msg48535 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2006-03-17 19:35
Logged In: YES 
user_id=849994

Waiting for input from OP.
msg48536 - (view) Author: SourceForge Robot (sf-robot) Date: 2006-04-01 03:20
Logged In: YES 
user_id=1312539

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
History
Date User Action Args
2022-04-11 14:56:12adminsetgithub: 42140
2005-06-29 07:47:31hendrikttcreate