➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Unchecked return value in cStringIO
Type: Stage:
Components: Extension Modules Versions:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: mwh Nosy List: mwh, spiv
Priority: normal Keywords: patch

Created on 2005-09-22 08:40 by spiv, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
cStringIO-listappend.diff spiv, 2005-09-22 08:40
cStringIO-listappend.diff spiv, 2005-09-22 09:03 Fixed patch.
Messages (3)
msg48750 - (view) Author: Andrew Bennetts (spiv) Date: 2005-09-22 08:40 
There's a PyList_Append call in IO_readlines that
doesn't have its return value checked.  This patch
fixes it.
msg48751 - (view) Author: Andrew Bennetts (spiv) Date: 2005-09-22 09:03 
Logged In: YES 
user_id=50945

Sorry, that patch was a brainfart.  Here's a saner one.
msg48752 - (view) Author: Michael Hudson (mwh) (Python committer) Date: 2005-09-22 09:20 
Logged In: YES 
user_id=6656

OK, this is checked in (along with your other patch) as:

Lib/test/test_StringIO.py revision 1.20
Misc/ACKS revision 1.296
Misc/NEWS revsision 1.1375
Modules/cStringIO.c revision 2.50

Thanks!
History
Date User Action Args
2022-04-11 14:56:13adminsetgithub: 42398
2005-09-22 08:40:32spivcreate