Logged In: YES
user_id=33168
Chad, I'm starting to look at this now, but it seems to be a
duplicate of your original patch # 1000267. Can this be
closed as a duplicate? I don't know if the attachments are
the same.
It would be easier to have all the changes in a single file.
Since you are adding a new file, you will need to use -N
option to cvs diff. Something like this: cvs diff -Nu ...
(you can list the specific files that changed if necessary).
From what I looked at so far, there were a couple of things
I didn't like. Though it looks like you addressed many
(perhaps all) of the previous comments.
I don't like the code in resourcemodule.h. I would prefer a
public API in resourcemodule that posixmodule can call. If
you think that no other modules outside python should call
this, you can prefix the name with _, ie
_PyResourceModule_...().
There are some un-prefixed names in resourcemodule.h. I
think these may all go away if you move the code into the .c
file. I would prefer to not have resourcemodule_h_author &
resourcemodule_h_rcsid. The comment with your name and
email is fine.
I didn't look at the test or usage example. What should be
done with the usage example? In the doc, could you remove
the ", ?" for availability. We can leave it as Unix for
now. If we find out definitive info about other platforms
(Windows, Mac), we can add that later. Please add a
\versionadded{2.5} at the end of the new doc (before the end).
That's all my comments. This looks close to being ready.
|