This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Python 2.4.2 doesn't build with "--without-threads"
Type: Stage:
Components: Build Versions: Python 2.4
process
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: nnorwitz Nosy List: fperrad, interneci, nnorwitz, phodifoo
Priority: normal Keywords: patch

Created on 2005-10-22 19:51 by interneci, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
without-threads-fix.patch interneci, 2005-10-22 19:51 Python 2.4.2 "--with-threads" build fix patch
Messages (5)
msg48887 - (view) Author: Gunter Ohrner (interneci) Date: 2005-10-22 19:51
Build fix is attached. (Not yet runtime tested.) 
msg48888 - (view) Author: Francois Perrad (fperrad) Date: 2005-10-28 07:22
Logged In: YES 
user_id=1293818

Just an alternate patch :

--- pystate.c.orig	2005-10-27 17:35:32.000000000 +0200
+++ pystate.c	2005-10-27 17:47:16.000000000 +0200
@@ -42,10 +42,14 @@
 */
 static PyInterpreterState *autoInterpreterState = NULL;
 static int autoTLSkey = 0;
+
+static void _PyGILState_NoteThreadState(PyThreadState* 
tstate);
 #else
 #define HEAD_INIT() /* Nothing */
 #define HEAD_LOCK() /* Nothing */
 #define HEAD_UNLOCK() /* Nothing */
+
+#define _PyGILState_NoteThreadState(tstate)
 #endif
 
 static PyInterpreterState *interp_head = NULL;
@@ -53,8 +57,6 @@
 PyThreadState *_PyThreadState_Current = NULL;
 PyThreadFrameGetter _PyThreadState_GetFrame = NULL;
 
-static void _PyGILState_NoteThreadState(PyThreadState* 
tstate);
-
 
 PyInterpreterState *
 PyInterpreterState_New(void)
msg48889 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2005-11-02 07:11
Logged In: YES 
user_id=33168

This was fixed a while ago.  Thanks.
msg48890 - (view) Author: phodifoo (phodifoo) Date: 2005-12-20 01:23
Logged In: YES 
user_id=1230133

> This was fixed a while ago.  Thanks.

but it still doesn't compile in 2.4.2
the fix has somehow been lost !!!
msg48891 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2005-12-20 01:34
Logged In: YES 
user_id=33168

It was fixed in CVS/SVN.  You will need to pull down the
changes from source.  When 2.4.3 is released it should
incorporate these changes.
History
Date User Action Args
2022-04-11 14:56:13adminsetgithub: 42511
2005-10-22 19:51:23internecicreate