This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Patch f. bug 495682 cannot handle http_proxy with user:pass@
Type: Stage:
Components: Library (Lib) Versions: Python 2.5
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: gvanrossum, jonico, loewis
Priority: normal Keywords: patch

Created on 2005-11-05 17:05 by jonico, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
urllib.py.patch2 jonico, 2005-12-13 17:37 second version of the patch (now also solves the traceback and the https retry problem)
Messages (5)
msg48966 - (view) Author: Johannes Nicolai (jonico) Date: 2005-11-05 17:05
solves problems for http and https proxies described in 
this bug 
solves tracebacks if proxy is specified for a protocol 
where no proxy is currently supported 
added dynamic proxy authentification for http and https 
solved bug that if a host accessed by the https protocol 
requires authentification, the https proxy won't be used 
after questioning the password 
msg48967 - (view) Author: Johannes Nicolai (jonico) Date: 2005-11-07 10:27
Logged In: YES 
user_id=863272

Perhaps some words about the accuracy of the patch: 
I have successfully tested it with squid 2.5 and squid 3.0 as http 
and https proxy with and without password. 
I used the integrated test routines in urllib.py 
msg48968 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2005-12-13 16:47
Logged In: YES 
user_id=6380

The patch looks good as a fix for bug 495682.

I don't see which lines in the patch warrant the claim
"solves tracebacks if proxy is specified for a protocol
where no proxy is currently supported" -- can you explain this?

I'd like you to request validation (testing) from someone
else on python-dev who can actually run this code -- I have
no way to verify that it works as advertised.
msg48969 - (view) Author: Johannes Nicolai (jonico) Date: 2005-12-13 17:30
Logged In: YES 
user_id=863272

Sorry, I have only uploaded an old version of the patch.  
There, the traceback problem was not solved at all 8-)  
I have now added the complete patch, that already relates 
to the newest version in the subversion repository.  
 
I will try to get another tester for my code, but it might 
be difficult.  
Unfortunately, only few people have an SSL capable proxy.   
msg48970 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-01-24 15:52
Logged In: YES 
user_id=21627

Thanks for the patch. Committed (with wording changes) as
r42171.
History
Date User Action Args
2022-04-11 14:56:13adminsetgithub: 42556
2005-11-05 17:05:57jonicocreate