This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: fix for resource leak in _subprocess
Type: Stage:
Components: Extension Modules Versions:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: effbot Nosy List: effbot, nnorwitz
Priority: normal Keywords: patch

Created on 2005-11-09 09:05 by effbot, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
patch-subprocess-2.txt effbot, 2005-11-10 22:48
Messages (4)
msg48995 - (view) Author: Fredrik Lundh (effbot) * (Python committer) Date: 2005-11-09 09:05
The _subprocess CreateProcess driver may leak if you
pass in an explicit environment dictionary.  This
trivial patch fixes this.

Can be backported to 2.3 and 2.4.
msg48996 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2005-11-10 05:53
Logged In: YES 
user_id=33168

/f did you want to check this in yourself?  I'm not sure if
you have an svn account or if you want one.  I can check it
in if you'd like.

See also bug #1346547.  There is another problem in this
area (lines 379/380) should check if an error occurred.  I
can't test this stuff, but if you test, I can check in.
msg48997 - (view) Author: Fredrik Lundh (effbot) * (Python committer) Date: 2005-11-10 22:48
Logged In: YES 
user_id=38376

I've updated the patch to address #1346547 as well.

If you have the time, feel free to check this in.  I don't
have a
proper account set up yet (but I promise to fix that soon).

thanks /F
msg48998 - (view) Author: Fredrik Lundh (effbot) * (Python committer) Date: 2005-11-12 10:26
Logged In: YES 
user_id=38376

MvL fixed my account, so I went ahead and checked this in.

This patch can be backported to all subprocess releases, but
I think the problem is relatively minor, so I won't do that now.
History
Date User Action Args
2022-04-11 14:56:14adminsetgithub: 42573
2005-11-09 09:05:52effbotcreate