This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Float marshaling problems with test_colorsys
Type: Stage:
Components: Interpreter Core Versions: Python 2.5
process
Status: closed Resolution: works for me
Dependencies: Superseder:
Assigned To: mwh Nosy List: arigo, georg.brandl, mwh, nnorwitz
Priority: high Keywords:

Created on 2005-11-30 19:49 by georg.brandl, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
colorsys.pyc.bad georg.brandl, 2005-11-30 19:49 "Bad" file (produced by make test)
colorsys.pyc.good georg.brandl, 2005-11-30 19:50 "Good" file (produced by direct call of test_colorsys)
Messages (10)
msg26949 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2005-11-30 19:49
Starting point: "make clean; make" in the 2.5 source tree.

"make test" hangs at test_colorsys.

Careful investigation shows that when the bytecode is
freshly generated
by "make all" (precisely in test___all__) the .pyc file
is different from what a
direct call to "regrtest.py test_colorsys" produces.

Curiously, a call to "regrtest.py test___all__" instead
of "make test" produces
the correct bytecode.

System is Linux 2.6, x86, gcc 3.4.4.

I have attached both versions of colorsys.pyc.
msg26950 - (view) Author: Armin Rigo (arigo) * (Python committer) Date: 2005-12-01 10:32
Logged In: YES 
user_id=4771

It's again a problem with floats.  For example, the constant 0.3 in rgb_to_yiq shows up as 0.0 in bad.pyc.  The constant 1.72986 shows up as 1.0.
msg26951 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2005-12-10 11:07
Logged In: YES 
user_id=1188172

Michael, you lately corrected a problem with floatobject.
Although the problem persists here, could it be caused by a
similar bug?
msg26952 - (view) Author: Michael Hudson (mwh) (Python committer) Date: 2005-12-10 11:43
Logged In: YES 
user_id=6656

I don't think so, no.  For a start, I can't reproduce the problem (mind you, I only 
use a Mac regularly these days).
msg26953 - (view) Author: Michael Hudson (mwh) (Python committer) Date: 2005-12-10 11:47
Logged In: YES 
user_id=6656

Also, is the problem reproducable on *your* system?  AFAIK, noone else has 
reproduced it, but I don't know how many people are actually running make test 
on development Python these days...
msg26954 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2005-12-10 13:35
Logged In: YES 
user_id=1188172

Yes, it is reproducable. If it's local to me, I don't know
what could be causing it.
I have a SVN tree without local changes on my local box and
my laptop, and both of them show the same bug.

I'll boot into some CD Linux later and see if the other
environment makes it vanish.
msg26955 - (view) Author: Michael Hudson (mwh) (Python committer) Date: 2005-12-10 13:42
Logged In: YES 
user_id=6656

Umpf.  I suppose the one remaining thing is you say you use "make clean".  This 
makes me very faintly suspicious that "make clean" doesn't really clean 
everything... could you maybe try a clean checkout?  Clutching at straws here, 
obviously.
msg26956 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2005-12-10 17:05
Logged In: YES 
user_id=1188172

Yep, after "make distclean" and even a fresh checkout the
problem is there. I configured with and without
"--with-pydebug".

Okay, Michael, you are rehabilitated: I restored
floatobject.c to the state before your patch, and it behaves
the same.
msg26957 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2005-12-11 20:05
Logged In: YES 
user_id=33168

I can't reproduce (make test) on linux 2.6, gcc 3.4.4, only
diff is amd64.  I have some outstanding changes, but none
that should affect the outcome.  Sorry, I don't know what to
tell you, can you try to debug any more?  Maybe run under
valgrind (or other memory debugger) and see if there's a
memory issue.
msg26958 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2006-01-06 19:23
Logged In: YES 
user_id=1188172

This has now vanished.
I don't know why, but I did a glibc update today, maybe...
History
Date User Action Args
2022-04-11 14:56:14adminsetgithub: 42646
2005-11-30 19:49:01birkenfeldcreate