➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Changes to nis module to support multiple NIS domains
Type: Stage:
Components: Extension Modules Versions: Python 2.4
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: csuwi, loewis, nnorwitz
Priority: normal Keywords: patch

Created on 2006-02-02 11:26 by csuwi, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
nismodule.patch csuwi, 2006-02-04 15:31
nis-test.patch csuwi, 2006-02-05 20:39
Messages (7)
msg49428 - (view) Author: Ben Bell (csuwi) Date: 2006-02-02 11:26 
The nis module currently has no way to access nis
domains other than the default NIS domain. This is
fairly easy to achieve via the C API and so I've
patched it.

Summary of changes:
I've added a new get_default_domain() function and
exposed it to python.

I've added an optional "domain" keyword arg to the cat,
maps and match arguments but defaulted it to the
default domain to ensure backwards compatibility.
msg49429 - (view) Author: Ben Bell (csuwi) Date: 2006-02-02 12:02 
Logged In: YES 
user_id=145982

The previous patch was a little lazy. I've now taken the
opportunity to add module doc and fix the two compile time
warnings as well. New diff attached.
msg49430 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-02-04 11:34 
Logged In: YES 
user_id=21627

Can you please attach the new patch to the report?
msg49431 - (view) Author: Ben Bell (csuwi) Date: 2006-02-04 15:32 
Logged In: YES 
user_id=145982

Sorry, uploaded this time
msg49432 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-02-04 19:14 
Logged In: YES 
user_id=21627

Thanks for the patch, committed as revision 42235.

In the future, please remember the following details:
- use PyDoc_STRVAR for documentation variables
- add changes to the tex documentation as well
msg49433 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2006-02-04 22:45 
Logged In: YES 
user_id=33168

Ben, could you also update Lib/test/test_nis.py to test the
new code?
msg49434 - (view) Author: Ben Bell (csuwi) Date: 2006-02-05 20:39 
Logged In: YES 
user_id=145982

Diff to test added.

Thanks for the tips on future changes. Noted.
History
Date User Action Args
2022-04-11 14:56:15adminsetgithub: 42860
2006-02-02 11:26:41csuwicreate