This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: patch for building trunk with VC6
Type: Stage:
Components: Windows Versions: Python 2.5
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: infidel, loewis, nnorwitz, ocean-city
Priority: normal Keywords: patch

Created on 2006-03-24 13:40 by ocean-city, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
vc6-25.zip ocean-city, 2006-09-21 18:31 files to replace PC/VC6 (I gave up to work on distutils)
vc6-25-update.zip ocean-city, 2006-10-16 11:44 patch for PC/VC6
Messages (13)
msg49848 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2006-03-24 13:40
Hello. I tried to build trunk with VC6, but failed.
The reasons are

 - _W64 is not defined on VC6. (PC/pyconfig.h)

 - intptr_t and uintptr_t are not decleared on VC6.
(should use Py_intptr_t and Py_uintptr_t respectively)

I'll submit the patch for these two issues as
"build_trunk_for_vc6.patch".

And more two issues.

 - zlib was make built into pythoncore, but
PC/VC6/pythoncore.dsp is not updated for it yet.

I'll submit the file itself.

 - long long cannot be used on VC6, so 0xFFFFULL is
failed to compile with "invalid suffix" error.

I workarounded this replaced ULL with UI64 (_int64's
suffix) but I don't know how to make the patch. maybe
can this tequnique be used?

  #define Py_ULL(x) x##ULL /* non VC6 */

  #define Py_ULL(x) x##UI64 /* VC6 */

  Py_ULL(0xFFFFFFFFFFFFFFFF) instead of 0xFFF...FULL

msg49849 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2006-03-26 17:02
Logged In: YES 
user_id=33168

Raymond, maybe this will help get VC6 building?
msg49850 - (view) Author: Luke Dunstan (infidel) Date: 2006-05-06 18:16
Logged In: YES 
user_id=30442

Is there anything preventing this patch from being 
applied? It would help me with building the trunk using 
both VC6 and Microsoft eMbedded Visual C++ 4.0 (for 
Windows CE).
msg49851 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2006-05-07 05:37
Logged In: YES 
user_id=1200846

Hello. I updated the patch. (Probably this is better)

  - defined ULL() macro locally in Modules/sha512module.c
      maybe it's better to declare Py_ULL or something
      globally, but I don't know how to do it.

 - more patch for zlib builtin (ie: PC/VC6/Readme.txt)

I cannot try this patch on VC7 or later, but
I confirmed lib/test/testall.py passed on VC6.
msg49852 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2006-05-07 05:40
Logged In: YES 
user_id=1200846

Oops, I forgot to upload the file.

  - Apply x.patch.

  - Replace pythoncore.dsp and pcbuild.dsw in PC/VC6 with
    attached files.

 - Remove PC/VC6/zlib.dsp

msg49853 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2006-05-25 04:33
Logged In: YES 
user_id=1200846

Thanks to Luke Dunstan, my patch becomes much smaller.

  - Replace *.dsp in PC/VC6 with attached files.

  - Remove PC/VC6/zlib.dsp

  - _sqlite3 and other new packages are not supported

I read core member are not interested in VC6 anymore, so
this is for VC6 guy. I don't want to install VC++2005Express
because it installs .net framework which I don't need. I'm
Java guy. :-)
msg49854 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2006-07-24 13:02
Logged In: YES 
user_id=1200846

This supports other packages other than _msi. (I skipped
this package because I don't know how to test it)

test case passed successfully.
msg49855 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-10-15 12:06
Logged In: YES 
user_id=21627

Many of these issues have been fixed. Can you please update
the patch again to fix the remaining ones?
msg49856 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2006-10-15 14:32
Logged In: YES 
user_id=1200846

I've done rough merge. But I don't understand every
difference between base and working copy, I'll check detail
tomorrow. (Some differences comes from the fact I copied
compiler options from other dsp files. But I don't know this
differences cause something)

This is current summary...

* zlib.dsp: no longer needed so removed.
* _sqlite3.dsp: added.
* _ssl.mak: /DWIN32 and user32.lib advapi32.lib are needed.
* _bsddb.dsp and others: use newer version of external files
like PCBuild.
* bz2.dsp: avoid "Special Build Tool". I experienced error
when built this module from VisualC++6 IDE. Need to build
bzip2-1.0.3 separately.
msg49857 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2006-10-16 11:44
Logged In: YES 
user_id=1200846

I updated patch. Addition to previous my comment....

* I believe no need to add header files into dsp files
because VC6 detects header modification and compiles
corresponding cpp files correctly.

* Still I don't know well, changed some compiler/linker
options to follow pythoncore.dsp way. (/o "NUL", /MTd=>/MDd
/ZI=>/Zi, SUBTRACT LINK32 /pdb:none,
ported /base value from PCBuild)

msg49858 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-10-17 15:24
Logged In: YES 
user_id=21627

Thanks for the patch. Committed as r52356 and r52357.

If you have further modifications to make, please submit
them as a new patch.
msg49859 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2006-10-17 18:00
Logged In: YES 
user_id=1200846

Thank you for commit. But, well, zlib.dsp still exists.
(empty file) Could you remove it from repositry?
msg49860 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-10-17 18:10
Logged In: YES 
user_id=21627

Thanks for pointing it out; done.
History
Date User Action Args
2022-04-11 14:56:16adminsetgithub: 43084
2006-03-24 13:40:49ocean-citycreate