➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Bug in threadmodule.c:local_traverse
Type: Stage:
Components: Extension Modules Versions:
process
Status: closed Resolution: not a bug
Dependencies: Superseder:
Assigned To: Nosy List: collinwinter, tim.peters
Priority: normal Keywords:

Created on 2006-04-19 02:34 by collinwinter, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
threadmodule.c.diff collinwinter, 2006-04-19 02:34 Patch for threadmodule.c, r45556
Messages (3)
msg28299 - (view) Author: Collin Winter (collinwinter) * (Python committer) Date: 2006-04-19 02:34 
threadmodule.c's local_traverse function does not call
Py_VISIT on self->key. Attached is a one-line patch
against r45556 to add the call.
msg28300 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2006-04-19 04:42 
Logged In: YES 
user_id=31435

It doesn't really matter:  self->key is either NULL or a
Python string object, and neither can be involved in a
cycle, so for purposes of cyclic gc it's just a waste of
time to pass the key to a visit() callback.   The docs could
be clearer about this.
msg28301 - (view) Author: Collin Winter (collinwinter) * (Python committer) Date: 2006-04-19 14:44 
Logged In: YES 
user_id=1344176

Aha. In which case, I'll work up a patch for the docs
instead. Thanks for the clairification. I'll go ahead and
close this report.
History
Date User Action Args
2022-04-11 14:56:16adminsetgithub: 43246
2006-04-19 02:34:12collinwintercreate