➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: SVN longobject.c compiler warnings
Type: Stage:
Components: Build Versions: Python 2.5
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: joeljkp, tim.peters
Priority: normal Keywords:

Created on 2006-05-24 15:31 by joeljkp, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
longobject.c.patch joeljkp, 2006-05-24 15:31 Patch
Messages (2)
msg28628 - (view) Author: Joel Parker (joeljkp) Date: 2006-05-24 15:31 
From SVN, longobject.c gives the following compiler
warnings (Sun Studio 11):

cc -xtarget=native64 -v -Xc -xc99=none -c  -DNDEBUG -O
 -I. -I./Include  -DPy_BUILD_CORE -o
Objects/longobject.o Objects/longobject.c
"Objects/longobject.c", line 1255: warning: statement
not reached
"Objects/longobject.c", line 1591: warning: statement
not reached
"Objects/longobject.c", line 1908: warning: statement
not reached
"Objects/longobject.c", line 1946: warning: statement
not reached

The attached patch fixes the problem.
msg28629 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2006-05-25 22:30 
Logged In: YES 
user_id=31435

Thanks for the patch!  I don't see an actual problem with
the code as it was, and expect the compiler warnings are
bogus.  But your patch shouldn't hurt either, and makes the
intent of the macro clearer to my eyes, so I applied it to
the trunk (for Python 2.5).
History
Date User Action Args
2022-04-11 14:56:17adminsetgithub: 43403
2006-05-24 15:31:17joeljkpcreate