This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: proposal for a new circle method
Type: Stage:
Components: Library (Lib) Versions: Python 2.5
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: loewis Nosy List: gregorlingl, loewis
Priority: normal Keywords: patch

Created on 2006-06-29 22:36 by gregorlingl, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
circle2.py gregorlingl, 2006-06-29 22:36 circle replacement and testcript
Messages (4)
msg50562 - (view) Author: Gregor Lingl (gregorlingl) Date: 2006-06-29 22:36
The attached file contains the proposal for 

(1) a new circle method (here called circle2)
(2) a new circle function (also called circle2)

Moreover it contains a testscript showing the
respective3 filling behaviour.

Visually they behave differently and it may well
be a point of discussion if this replacement
schould be made.

circle2 has correct filling behaviour and doesn't
show the strange 'not drawing feature' after a
radians() call.

All the other problems with radians()/degrees()
remain. (see #1514685)

msg50563 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-06-30 16:44
Logged In: YES 
user_id=21627

New methods are not acceptable for Python 2.5 at this point.

Can you think of a reason why this should *not* become the
circle method? I understand that this fixes a bug, right?
msg50564 - (view) Author: Gregor Lingl (gregorlingl) Date: 2006-06-30 19:23
Logged In: YES 
user_id=1547199

A misinterpretation:
I think it *should* become the circle method. (It were a 
weird idea to introduce a circle2 method anyway). I only
named it circle2 for now and test purposes in order to 
compare the behaviours of the two. If you are content
with the patch, replace circle by circle2 'as circle' - if
not leave circle2 out and let everything as is. Imho the 
the points to think about are:
(i) is the polygon approximation ok? I think, my testscript
gives a positive answer: the polygons are visually nearly
indistiguishable from the canvas circle items. (Moreover I
tested it with radiuses in the range from 1 to 200
successfully) 
(ii)that the new method relies on the forward method and
thus circles are drawn much slower. For me this is quite ok. 
msg50565 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-07-03 10:06
Logged In: YES 
user_id=21627

Thanks for the patch. Committed as r47209.
History
Date User Action Args
2022-04-11 14:56:18adminsetgithub: 43585
2006-06-29 22:36:27gregorlinglcreate