PyShell.recall uses wrong indentation logic when
recalling a block of code (more than one line).

It first inserts the first line and calls
newline_and_indent, which inserts a newline and indents
the next line according to heuristics - more indent
after ':', less after a return, etc. So far so good.

Afterwards, for each following line, it just inserts
line.strip(), and again calls newline_and_indent. This
often ruins the block's indentation, for instance at
the end of loops and 'if' blocks.

This can easily be improved upon since we have the
original indentation. This patch retains the block's
original indentation, only adjusting it to fit the
current base indentation level.

This patch also doesn't add an extra newline at the end
of a recalled block, unless there was on there originally.

I haven't tested it thoroughly but I have played around
with it a lot and tweaked it. So far it seems to work 100%.

Logged In: YES 
user_id=149084

Well, once you get it throughly tested, please
attach the patch so I can look at it.

Logged In: YES 
user_id=1330769

Bah, sorry for forgetting to post the file... It really was
getting late that night :P

Logged In: YES 
user_id=1330769

I uploaded an update (another patch, apply after applying
the first one), this fixes the behavior a bit.

Logged In: YES 
user_id=149084

2.5b3 Rev 51189.  Thanks for the patch!

Logged In: YES 
user_id=149084

2.5b3 Rev 51189.  Thanks for the patch!