This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: CodeContext visibility
Type: Stage:
Components: IDLE Versions: Python 2.6
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: kbk Nosy List: jimjjewett, kbk, taleinat
Priority: normal Keywords: patch

Created on 2006-08-15 19:20 by jimjjewett, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
idlecodecontextdisplay.patch.txt jimjjewett, 2006-08-15 19:20
Messages (6)
msg50900 - (view) Author: Jim Jewett (jimjjewett) Date: 2006-08-15 19:20
CodeContext hardcodes several constants; these two in 
particular make it difficult to visually separate the 
"context" from the top of the regular code. 

Ideally, the measurement would change to something 
like em or ex, but ... this was an improvement.  

Note that the separation is explicitly there in the 
code already; it just doesn't work with the current 
constants.  If the Relesae Manager decides to delay it 
to 2.6 (or backport to 2.4), I won't object.

msg50901 - (view) Author: Tal Einat (taleinat) * (Python committer) Date: 2006-08-16 15:40
Logged In: YES 
user_id=1330769

I originally wrote the code with those constants.

I used those constants because I specifically wanted to line
up the CodeContext code with the code in the main window,
for easier reading. Your patch does the exact opposite - it
pushes the CodeContext code way to the right. IMO, since the
purpose of CodeContext is to have the current scope easily
seen, having the code aligned is vital.

You may prefer dis-alignment because it's easier to tell
CodeContext apart, but that's just a personal preference,
and IMO not something that should be the default behavior of
IDLE.

Personally, I find that CodeContext's different background
color is more than enough to distinguish it from the main
editor window. CodeContext's background and foreground
colors are configurable (in config-extensions), you can
always choose colors you like better.

Tal
msg50902 - (view) Author: Jim Jewett (jimjjewett) Date: 2006-08-16 17:18
Logged In: YES 
user_id=764593

ahh ... I hadn't even noticed the (effectively one-
character) horizontal change.  

The change I aimed for (which I thought was the goal of the 
pad frame) was a slight *vertical* separation between the 
parts.  

So definately not until 2.6, and hopefully the eventual 
replacement will be better than what I posted here.  Thank 
you for the clarification.
msg50903 - (view) Author: Jim Jewett (jimjjewett) Date: 2006-08-16 17:19
Logged In: YES 
user_id=764593

ahh ... I hadn't even noticed the (effectively one-
character) horizontal change.  

The change I aimed for (which I thought was the goal of the 
pad frame) was a slight *vertical* separation between the 
parts.  

So definately not until 2.6, and hopefully the eventual 
replacement will be better than what I posted here.  Thank 
you for the clarification.
msg50904 - (view) Author: Tal Einat (taleinat) * (Python committer) Date: 2006-12-09 16:51
Increasing the vertical separation is a possibility, but I think this is mostly a matter of taste.

Personally, I prefer to differentiate between the code and context with a different backgroud than to have a large blank separator. (Note that the background and foreground colors of the context are configurable.)

In any case, just increasing the border ruins the horizontal alignment. This should be done with 'pady' or by adding a padding frame below the context window.
msg50905 - (view) Author: Kurt B. Kaiser (kbk) * (Python committer) Date: 2007-02-05 04:04
I agree with Tal Einat on this.
History
Date User Action Args
2022-04-11 14:56:19adminsetgithub: 43831
2006-08-15 19:20:29jimjjewettcreate