This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix for structmember conversion issues
Type: Stage:
Components: Interpreter Core Versions: Python 2.5
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: loewis, rupole
Priority: normal Keywords: patch

Created on 2006-08-30 04:50 by rupole, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
structmember.patch rupole, 2006-08-30 04:50
_testcapimodule.patch rupole, 2006-08-30 04:51
test_structmembers.py rupole, 2006-08-30 04:53
Messages (3)
msg51020 - (view) Author: Roger Upole (rupole) Date: 2006-08-30 04:50
This patch is for bug# 1545696.
Patches created against 2.5c1.
msg51021 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-10-27 06:02
Logged In: YES 
user_id=21627

A few comments:
- the truncation of float values should not cause a warning.
float values will always be truncated (i.e. lose precision)
when written to T_FLOAT; there's really no way to avoid that.
- that PyObject_HEAD_INIT can sometimes be used is because
these initializations occur within the same DLL
(pythonxy.dll). It is cross-DLL access to addresses of
global variables which Windows doesn't support.
- I restored support for passing negative values into
T_UINT/T_ULONG
msg51022 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-10-27 06:19
Logged In: YES 
user_id=21627

Thanks for the patch. I committed it, with modifications, as
r52452 for the trunk, and r52453 for the 2.5 branch. In the
2.5 branch, I removed the warnings.

Please review my changes to find out errors I may have made.
History
Date User Action Args
2022-04-11 14:56:19adminsetgithub: 43913
2006-08-30 04:50:03rupolecreate