➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix for rpartition() end-case
Type: Stage:
Components: Interpreter Core Versions: Python 2.5
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: nnorwitz Nosy List: ncoghlan, nnorwitz, rhettinger
Priority: high Keywords: patch

Created on 2006-09-03 06:48 by rhettinger, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
rpart.diff rhettinger, 2006-09-03 06:48 rpartition() patch
Messages (4)
msg51063 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2006-09-03 06:48 
Per discussion on python-dev
msg51064 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2006-09-04 13:07 
Logged In: YES 
user_id=1038590

Aside from the tests, the patch looks OK. (A search through
the standard library showed that the only current use of
rpartition() is in UserString.py, which will correctly
inherit the behaviour of the underlying string type).

For the tests, the degenerate cases are already tested
(second test in each group), so new test cases aren't
necessary. Instead, the expected result for the degenerate
rpartition test needs to be updated. (Also, the second test
case added by the patch invoked partition() instead of
rpartition())
msg51065 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2006-09-04 22:20 
Logged In: YES 
user_id=80475

Neal, please move this from the head to the release branch 
when you're ready.  Nick, thanks for the review.
msg51066 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2006-09-05 02:21 
Logged In: YES 
user_id=33168

This patch is different than what's on HEAD (some files, in
particular partition.h and string_tests.py).  HEAD passes,
this one doesn't.  I'm using the version from head.

Committed revision 51718.
History
Date User Action Args
2022-04-11 14:56:19adminsetgithub: 43932
2006-09-03 06:48:55rhettingercreate