This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Backward incompatibility in logging.py
Type: Stage:
Components: Library (Lib) Versions: Python 2.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: nnorwitz Nosy List: georg.brandl, klaas, nnorwitz, vinay.sajip
Priority: critical Keywords:

Created on 2006-10-02 23:10 by klaas, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (9)
msg30128 - (view) Author: Mike Klaas (klaas) Date: 2006-10-02 23:10
LogRecord.__init__ changed in a backward incompatible
way in python 2.5 (added one parameter).  

There is no mention of this breakage in the release
notes, nor has the documentation of the module been
updated (http://docs.python.org/lib/node424.html)
msg30129 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2006-10-03 06:11
Logged In: YES 
user_id=849994

I don't see why adding one parameter is backwards
incompatible, but it's true that the docs must be updated.
Assigning to Vinay.
msg30130 - (view) Author: Mike Klaas (klaas) Date: 2006-10-03 17:14
Logged In: YES 
user_id=1611720

It is incompatible as code written for 2.4 will break in
2.5, and vice-versa (this is a required parameter, not an
optional parameter, and the change could have been made in a
backward-compatible way).

You're right that the documentation fix is the important thing.

msg30131 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2006-10-03 18:22
Logged In: YES 
user_id=308438

Documentation now updated in CVS. Also changed the added
"func" parameter to have a default value of None.

Sorry for the inconvenience caused.
msg30132 - (view) Author: Mike Klaas (klaas) Date: 2007-01-08 02:19
This fix should be back-ported to 2.5 maint:

r52100,52101,52102

perhaps also r52555,52556?
msg30133 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2007-01-08 10:13
Done. I'm not sure what you're getting at with those revision numbers - trunk and branches/release25-maint are now up to date; if you think other branches need to be updated, please name those branches explicitly.
msg30134 - (view) Author: Mike Klaas (klaas) Date: 2007-01-08 18:07
Sorry - I was just trying to to see if the fix was backported, and I only saw the trunk checkins on python-checkins 
msg30135 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2007-01-08 18:26
No need to be sorry, you were absolutely right to re-open the issue for backports - I had not originally checked in the backport. What I meant in my last mail was that I have now checked in the backport, but wasn't sure about the specific revisions you were referring to.

Thanks for the reminder about release25-maint.
msg30136 - (view) Author: Mike Klaas (klaas) Date: 2007-01-08 18:30
Ah... the revisions were simply the fix revisions (the last two were not directly related to this issue, but one was a documentation bug, and the other was a minor performance edit, so I thought those might also be backport candidates).
History
Date User Action Args
2022-04-11 14:56:20adminsetgithub: 44070
2006-10-02 23:10:28klaascreate