➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: typo in PC/_msi.c
Type: Stage:
Components: Interpreter Core Versions: Python 2.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: georg.brandl Nosy List: georg.brandl, jnazario
Priority: normal Keywords: patch

Created on 2006-10-07 13:17 by jnazario, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (4)
msg51207 - (view) Author: jose nazario (jnazario) Date: 2006-10-07 13:17 
basic typo in PC/_msi.c, assignment vs comparison (fat
fingered?)

not sure of the implications, but it looks like more of
a relibility fix than anything. 

--- PC/_msi.c.orig      Sat Oct  7 09:12:46 2006
+++ PC/_msi.c   Sat Oct  7 09:12:59 2006
@@ -495,7 +495,7 @@
 
     status = MsiSummaryInfoGetProperty(si->h, field,
&type, &ival, 
        &fval, sval, &ssize);
-    if (status = ERROR_MORE_DATA) {
+    if (status == ERROR_MORE_DATA) {
        sval = malloc(ssize);
         status = MsiSummaryInfoGetProperty(si->h,
field, &type, &ival, 
            &fval, sval, &ssize);
msg51208 - (view) Author: jose nazario (jnazario) Date: 2006-10-07 13:17 
Logged In: YES 
user_id=350099

PS: verified this is also present in the latest SVN repository. 

http://svn.python.org/view/python/trunk/PC/_msi.c?rev=42848&view=markup
msg51209 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2006-10-07 13:22 
Logged In: YES 
user_id=849994

Assigning to Martin.
msg51210 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2006-10-09 19:03 
Logged In: YES 
user_id=849994

Fixed in rev. 52251, 52252 (2.5).
History
Date User Action Args
2022-04-11 14:56:20adminsetgithub: 44096
2006-10-07 13:17:13jnazariocreate