This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: MacPython Build Installer - Typos and Style corrections
Type: Stage:
Components: macOS Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ronaldoussoren Nosy List: jackjansen, ronaldoussoren, virtualspirit
Priority: normal Keywords: patch

Created on 2006-11-02 05:44 by virtualspirit, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
macpython-build-typos_and_style.patch virtualspirit, 2006-11-02 05:44 MacPython build - typos and style corrections
Messages (5)
msg51312 - (view) Author: Humberto Diógenes (virtualspirit) Date: 2006-11-02 05:44
 * Corrected many typos (such as "IDLE is an IDLE" instead of "IDLE is an 
IDE");
 * Simplified SRCDIR guessing;
 * PEP8 style;

Includes patch #1589013 ("Univeral" MacPython).
msg51313 - (view) Author: Jack Jansen (jackjansen) * (Python committer) Date: 2006-11-02 12:51
Logged In: YES 
user_id=45365

Ronald, aside from a number of typo fixes (it took me 5 minutes to see that there's an "s" missing in "Univeral MacPython" :-) there's also some 
changes in the logic; those probably need some eyeballing over (the changes to SRCDIR look a bit suspect).
msg51314 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2006-11-07 15:37
Logged In: YES 
user_id=580910

The change to SRCDIR looks bogus and even if it works I find the current version more readable. That will definitely not go in.

I will apply the typo fixes, and may do the same with the style changes.

BTW. Humberto, it would be better to split the formatting changes from functional changes in future patches. We now had to hunt down the 
patch fragments that weren't formatting changes. Anyway, thanks for the patch.
msg51315 - (view) Author: Humberto Diógenes (virtualspirit) Date: 2006-11-07 15:55
Logged In: YES 
user_id=736405

Yes, after Jack's comment I noticed it was a really bad idea to mix these changes. Thanks for accepting it anyway! :)
msg51316 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2006-11-07 16:01
Logged In: YES 
user_id=580910

I've commited the typo fixes as 52644 (trunk), 52645 (2.5 branch), 52646 (2.4 branch). The PEP8 style changes were applied in revision 52647 
on the trunk. 
History
Date User Action Args
2022-04-11 14:56:21adminsetgithub: 44187
2006-11-02 05:44:49virtualspiritcreate