This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: urllib HTTPS Basic authentication fix
Type: Stage:
Components: Library (Lib) Versions: Python 2.5
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: akuchling Nosy List: akuchling, dugsong
Priority: normal Keywords: patch

Created on 2006-12-17 16:05 by dugsong, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
urllib.diff dugsong, 2006-12-17 16:05 Python 2.5 urllib.py HTTPS authentication fix
Messages (2)
msg51552 - (view) Author: Dug Song (dugsong) Date: 2006-12-17 16:05
urllib's support for HTTP Basic authentication via HTTPS is broken, due to an invalid call in URLopener.open_https() to HTTPConnection.putheader() (apparently miscopied from URLopener.open_http(), which gets it right). the code incorrectly calls putheader with a fully formatted header instead of passing a name and value separately, resulting in a badly formatted header ending with a trailing colon.

the fix is trivial.
msg51553 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2006-12-19 15:14
Thanks for the fix!  Applied to trunk in rev. 53068 and to 25-maint in rev. 53069.
History
Date User Action Args
2022-04-11 14:56:21adminsetgithub: 44346
2006-12-17 16:05:48dugsongcreate