This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: PyFloat_FromString deprecated form
Type: Stage:
Components: None Versions: Python 3.0
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: georg.brandl, gvanrossum, jimjjewett
Priority: normal Keywords:

Created on 2007-02-02 19:41 by jimjjewett, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (6)
msg31165 - (view) Author: Jim Jewett (jimjjewett) Date: 2007-02-02 19:41
PyFloat_FromString takes two arguments, and the only purpose of the second is to avoid changing the API.

Extracts from Tim's 2000 comment:


Since we can't change the interface of a public API function, pend is still supported but now *officially* useless:  if pend is not NULL, *pend is set to NULL.
msg31166 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2007-03-06 18:53
What do you propose to do?
msg31167 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2007-03-06 18:54
(cont'd)
C API functions shouldn't even change signature in Py 3000. Therefore, a new name would be needed...
msg31168 - (view) Author: Jim Jewett (jimjjewett) Date: 2007-03-07 00:06
I didn't realize that a decision had been made about the C API stability.

I would indeed propose changing it, but probably not if it the rest of the API (even for strings and unicode?) is supposed to stay stable.
msg31169 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2007-03-18 03:55
I think I should relax that statement a bit. IMO it's OK to change the signature (for Py3k) since the compiler will report an error if you call it with the old signature.  What's *not* OK is to keep the signature (or to keep it compatible anyway) but change the *behavior*, as that would cause bugs that are only caught (if at all) at runtime, and will hence be hard to debug.  Examples of bad changes would be changing the reference count behavior of an API, changing the type of object returned (if a specific type was previously documented) or making it possible to return NULL where this was previous not possible.
msg31170 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2007-03-18 18:35
Okay, I fixed this case in rev. 54433.
History
Date User Action Args
2022-04-11 14:56:22adminsetgithub: 44541
2008-01-06 22:29:46adminsetkeywords: - py3k
versions: + Python 3.0
2007-02-02 19:41:29jimjjewettcreate