This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix test_urllib on Windows buildbots
Type: Stage:
Components: Tests Versions: Python 2.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: zseil Nosy List: nnorwitz, zseil
Priority: normal Keywords: patch

Created on 2007-04-06 23:03 by zseil, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
cleanup_testdirs.diff zseil, 2007-04-06 23:03 patch against trunk revision 54707
cleanup_cleanup.diff zseil, 2007-04-06 23:06 apply when the first patch has cleaned up
Messages (5)
msg52394 - (view) Author: Ziga Seilnacht (zseil) * (Python committer) Date: 2007-04-06 23:03
test_urllib is currently failing on Windows buildbots
because test_os at one time created a directory named
test_support.TESTFN + ".2".  test_os has been fixed,
but the old directory is still present on buildbots.

This patch is a one time fix that should be removed
after the first succesful buildbot run.  I added the
cleanup code to test_urllib, because buildbots run
tests in random order.

The other option is to ask the buildbot slave
maintainers to manually remove the offending directory.

msg52395 - (view) Author: Ziga Seilnacht (zseil) * (Python committer) Date: 2007-04-06 23:06
Here is the second patch that should be applied
once the first one has done its job.  It also
removes Neal's cleanups, because they are not
needed anymore.
File Added: cleanup_cleanup.diff
msg52396 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2007-04-09 18:10
Ziga, if this passes on windows, please apply to trunk.  2.5 branch is stilly frozen (I forget if this is trunk only). Thanks for backing out my changes.  They never did much.
msg52397 - (view) Author: Ziga Seilnacht (zseil) * (Python committer) Date: 2007-04-09 20:15
I checked in the first patch, and it fixed the problem on
the Windows 2000 buildbot slave.  I'm not entirely sure how
the buildbot works, so I would like to wait with the second
patch until the Windows XP slave comes back online.

The test was failing only on the trunk, so there is no
need to backport this change.
msg52398 - (view) Author: Ziga Seilnacht (zseil) * (Python committer) Date: 2007-04-12 09:37
Commited the second patch in r54785.
History
Date User Action Args
2022-04-11 14:56:23adminsetgithub: 44812
2007-04-06 23:03:13zseilcreate