This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: svnversion_init assertion failed
Type: Stage:
Components: Interpreter Core Versions: Python 2.5
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: nnorwitz Nosy List: ajrh, loewis, nnorwitz
Priority: normal Keywords:

Created on 2007-04-16 00:45 by ajrh, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (6)
msg31798 - (view) Author: ajrh (ajrh) Date: 2007-04-16 00:45
python: src/python-2.5.1c1/Python/sysmodule.c:1000: svnversion_init: Assertion `len >= 13' failed.

I see these assertions were added here:
http://mail.python.org/pipermail/python-checkins/2006-October/057079.html

Given the form of the subversion headurl string, the assertion doesn't appear to me at first glance to be valid.


msg31799 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2007-04-16 05:03
Neal, can you take a look? The assert really does not make sense to me. How did you arrive at 13?
msg31800 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2007-04-16 05:34
Unfortunately I don't recall.  Looking at the code, my guess is that I added the assertion into the wrong code block.  The next code block down requires len >= 13.  I'll move it on head, shall I remove it for 2.5.1, then add it back in the proper place for 2.5.2?
msg31801 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2007-04-16 06:09
Anthony agreed that the assert should be removed for 2.5.1.
msg31802 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2007-04-16 06:13
Committed revision 54836. (2.5) - Remove the 2 assertions.

I still need to fix up head.  I also noticed I botched the second assert.  - should be +.  I'll test this and verify the fix before fixing head.
msg31803 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2007-04-16 07:40
Committed revision 54841. (trunk)

I think I'll just leave this out of 2.5 given how badly I botched this the first time.

I did test this and ensure that both branches worked this time.  For the first block, I triggered istag by adding tag to the headurl.  For the second block I #undef SVNVERSION in Modules/getbuildinfo.c to verify the exported version works too.
History
Date User Action Args
2022-04-11 14:56:23adminsetgithub: 44852
2007-04-16 00:45:16ajrhcreate