➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: textView code cleanup
Type: Stage:
Components: IDLE Versions:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: kbk Nosy List: kbk, taleinat
Priority: low Keywords: patch

Created on 2007-05-13 08:27 by taleinat, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
IDLE_textView.070513.patch taleinat, 2007-05-13 08:27 Initial patch
Messages (2)
msg52619 - (view) Author: Tal Einat (taleinat) * (Python committer) Date: 2007-05-13 08:27 
I refactored textView a bit:

1) Moved file/text logic out of the TextViewer class. The constructor is now called with the text to be shown, instead of being called with either a filename or text, which made calls to it ugly.

2) Moved duplicate logic found in TextViewer and aboutDialog.py into a utility function, textView.view_file.

3) Created new utility function, textView.view_text (also used by view_file).

4) Updated test code to test both utility functions.


Changed EditorWindow.py and aboutDialog.py to use these new utility functions (improved readability).
msg56222 - (view) Author: Kurt B. Kaiser (kbk) * (Python committer) Date: 2007-10-04 02:54 
r58309.  Thanks for the Patch!
History
Date User Action Args
2022-04-11 14:56:24adminsetgithub: 44950
2007-10-04 02:54:08kbksetstatus: open -> closed
assignee: kbk
resolution: accepted
messages: + msg56222
nosy: + kbk
2007-05-13 08:27:53taleinatcreate