This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Distutils default exclude doesn't match top level .svn
Type: Stage:
Components: Distutils Versions: Python 2.6, Python 2.5
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: georg.brandl Nosy List: betelgeus, draghuram, georg.brandl, loewis, schmir
Priority: normal Keywords: patch

Created on 2007-05-25 16:44 by betelgeus, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
distutils-top-level-vcs.patch betelgeus, 2007-05-25 16:44 distutils-top-level-vcs.patch
ex.tgz schmir, 2008-02-23 23:10 example dummy distribution
more-vcs-exclude.txt schmir, 2008-02-23 23:34 fix original issue and exclude some more vcs dirs
more-vcs-exclude+docs.txt schmir, 2008-02-23 23:50 now with patches for documentation also.
Messages (21)
msg52665 - (view) Author: Petteri Räty (betelgeus) Date: 2007-05-25 16:44
betelgeuse@pena ~/java-config-trunk $ cat MANIFEST.in 
global-include *
prune make-release

Gives me:
hard linking .svn/all-wcprops -> java-config-2.0.33/.svn
hard linking .svn/dir-prop-base -> java-config-2.0.33/.svn
hard linking .svn/entries -> java-config-2.0.33/.svn
hard linking .svn/format -> java-config-2.0.33/.svn
hard linking .svn/prop-base/make-release.svn-base -> java-config-2.0.33/.svn/prop-base
hard linking .svn/text-base/AUTHORS.svn-base -> java-config-2.0.33/.svn/text-base
hard linking .svn/text-base/MANIFEST.in.svn-base -> java-config-2.0.33/.svn/text-base
hard linking .svn/text-base/NEWS.svn-base -> java-config-2.0.33/.svn/text-base
hard linking .svn/text-base/TODO.svn-base -> java-config-2.0.33/.svn/text-base
hard linking .svn/text-base/make-release.svn-base -> java-config-2.0.33/.svn/text-base
hard linking .svn/text-base/setup.py.svn-base -> java-config-2.0.33/.svn/text-base

The documentation on the other hand says:
          * any RCS, CVS and .svn directories
msg52666 - (view) Author: Raghuram Devarakonda (draghuram) (Python triager) Date: 2007-05-29 18:32

Can you tell the exact command you ran to get the above output?
msg52667 - (view) Author: Petteri Räty (betelgeus) Date: 2007-05-29 19:07
python setup.py sdist --formats=bztar
msg52668 - (view) Author: Raghuram Devarakonda (draghuram) (Python triager) Date: 2007-05-29 21:58
I tested with latest built python on Linux but couldn't reproduce the problem. I created directories .svn in distribution root directory as well as under "foobar". Both of them got skipped. It will be helpful if you can create a very small distribution manifesting reported problem and upload tar.gz file here. I can then give a try using that distribution.
msg52669 - (view) Author: Petteri Räty (betelgeus) Date: 2007-05-29 22:04
Did you use global-include * in MANIFEST.in?
msg52670 - (view) Author: Raghuram Devarakonda (draghuram) (Python triager) Date: 2007-05-29 22:06
I did.
msg59903 - (view) Author: Raghuram Devarakonda (draghuram) (Python triager) Date: 2008-01-14 16:45
I suggest this bug be closed as invalid.
msg59959 - (view) Author: Ralf Schmitt (schmir) Date: 2008-01-15 07:55
I can easily reproduce it using python 2.5.
I'll test with trunk.
msg62836 - (view) Author: Ralf Schmitt (schmir) Date: 2008-02-23 23:10
running setup.py sdist --prune results in:

making hard links in ex-0.0.0...
hard linking MANIFEST.in -> ex-0.0.0
hard linking setup.py -> ex-0.0.0
hard linking .hg/00changelog.i -> ex-0.0.0/.hg
hard linking .hg/dirstate -> ex-0.0.0/.hg
hard linking .hg/requires -> ex-0.0.0/.hg
hard linking .hg/undo.branch -> ex-0.0.0/.hg
hard linking .hg/undo.dirstate -> ex-0.0.0/.hg
hard linking .hg/store/00changelog.i -> ex-0.0.0/.hg/store
hard linking .hg/store/00manifest.i -> ex-0.0.0/.hg/store
hard linking .hg/store/undo -> ex-0.0.0/.hg/store
hard linking .hg/store/data/_m_a_n_i_f_e_s_t.in.i -> ex-0.0.0/.hg/store/data
hard linking .hg/store/data/setup.py.i -> ex-0.0.0/.hg/store/data
hard linking .svn/entries -> ex-0.0.0/.svn
creating dist
tar -cf dist/ex-0.0.0.tar ex-0.0.0
gzip -f9 dist/ex-0.0.0.tar
removing 'ex-0.0.0' (and everything under it)
msg62837 - (view) Author: Ralf Schmitt (schmir) Date: 2008-02-23 23:11
.hg, .git, are also candidates
msg62840 - (view) Author: Ralf Schmitt (schmir) Date: 2008-02-23 23:21
.bzr, and _darcs (yes, underscore) also.
msg62845 - (view) Author: Ralf Schmitt (schmir) Date: 2008-02-23 23:34
updated version of diff, which also excludes .hg, .git, .bzr, and _darcs.
msg62846 - (view) Author: Ralf Schmitt (schmir) Date: 2008-02-23 23:50
also patch docs.
msg62853 - (view) Author: Ralf Schmitt (schmir) Date: 2008-02-24 00:21
http://bugs.python.org/issue1095784 proposes to exclude:
.#*  (CVS conflict files, but emacs sometimes also generates them)

*~ would also be a candidate
msg62979 - (view) Author: Ralf Schmitt (schmir) Date: 2008-02-25 12:36
The original patch should by betelgeus should be applied to 2.5 branch.

Georg, this is complete from my point of view and could be applied.
Unless you want *~ and .#* to also be excluded?
msg63304 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2008-03-06 06:47
Committed as r61263. I'll let Martin decide about a backport.
msg63307 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2008-03-06 07:15
Backported as r61268. Georg, can you please add a NEWS entry for the
trunk as well?
msg63311 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2008-03-06 07:43
Done!
msg63314 - (view) Author: Ralf Schmitt (schmir) Date: 2008-03-06 09:18
_svn might also be a candidate. it is used on windows when
SVN_ASP_DOT_NET_HACK is set.
(see http://svn.collab.net/repos/svn/trunk/notes/asp-dot-net-hack.txt).
But, I don't care enough to provide a patch.

What do you thinkm about excluding *~ and .*# ?
msg63327 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2008-03-06 18:11
-1 on including anything that is a temporary file of some program. It's
the job of the packager to clean the directory before packaging. I
personally don't want to spend any more time on this issue.
msg63342 - (view) Author: Ralf Schmitt (schmir) Date: 2008-03-06 23:52
then close this one and also http://bugs.python.org/issue1095784
History
Date User Action Args
2022-04-11 14:56:24adminsetgithub: 44994
2008-03-06 23:52:14schmirsetmessages: + msg63342
2008-03-06 18:11:43loewissetmessages: + msg63327
2008-03-06 09:18:26schmirsetmessages: + msg63314
2008-03-06 07:43:22georg.brandlsetmessages: + msg63311
2008-03-06 07:15:51loewissetassignee: loewis -> georg.brandl
messages: + msg63307
2008-03-06 06:47:45georg.brandlsetstatus: open -> closed
assignee: loewis
resolution: accepted
messages: + msg63304
nosy: + loewis
2008-02-25 12:36:29schmirsetmessages: + msg62979
versions: + Python 2.6, Python 2.5
2008-02-24 00:21:14schmirsetmessages: + msg62853
2008-02-23 23:51:18schmirsetnosy: + georg.brandl
2008-02-23 23:50:36schmirsetfiles: + more-vcs-exclude+docs.txt
messages: + msg62846
2008-02-23 23:34:44schmirsetfiles: + more-vcs-exclude.txt
messages: + msg62845
2008-02-23 23:21:12schmirsetmessages: + msg62840
2008-02-23 23:11:36schmirsetmessages: + msg62837
2008-02-23 23:10:50schmirsetfiles: + ex.tgz
messages: + msg62836
2008-01-15 07:55:08schmirsetmessages: + msg59959
2008-01-14 23:51:07schmirsetnosy: + schmir
2008-01-14 16:45:07draghuramsetmessages: + msg59903
2007-05-25 16:44:44betelgeuscreate