This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Some fix abount _WIN32_WINNT
Type: Stage:
Components: Interpreter Core Versions: Python 2.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: mhammond Nosy List: loewis, mhammond, ocean-city
Priority: normal Keywords: patch

Created on 2007-07-27 06:57 by ocean-city, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
a.patch ocean-city, 2007-07-27 06:57
Messages (4)
msg52953 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2007-07-27 06:57
http://mail.python.org/pipermail/python-checkins/2007-July/061251.html
Due to r56561 change, VC6 fails to compile Module/posixmodule.c, becaue Crypt API needs _WIN32_WINNT  definition. I'll atach the fix patch.

1. Fix a typo in PC/pyconfig.h.
2. Still compile fails, because Py_BUILD_CORE seems not to be defined on VC6 build system. I greped, and found that it's only defined on VC8(PCBuild8/pythoncore/pythoncore.vcproj). Maybe it's right fix to define Py_BUILD_CORE on all platforms, but I don't know the meaning of this macro, so I simply reverted r55103 change which removed local _WIN32_WINNT definition in Module/posixmodule.c.

msg52954 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2007-07-28 11:43
Mark, since this was your checkin: Can you take a look?

If not, please unassign.
msg52955 - (view) Author: Mark Hammond (mhammond) * (Python committer) Date: 2007-07-30 00:45
This was my fault - Py_BUILD_CORE is defined in that same .h file - but after my new block which tested for it.  I'd forgotten the build systems still  define USE_DL_EXPORT instead of directly defining Py_BUILD_CORE and I should have checked.

The error was compounded by the fact that a VC2003 build does *not* require these definitions.  I can't see VC6 build files for the svn trunk, so I'm unable to test that posixmodule works with that compiler - but it *should* work, assuming my fix means that posixmodule will now see the #define in pyconfig.h

Fixed in r56624
msg52956 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2007-07-30 01:48
Thank you, I confirmed your fix worked fine.
History
Date User Action Args
2022-04-11 14:56:25adminsetgithub: 45249
2007-07-27 06:57:45ocean-citycreate