This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix for failing test_scriptpackages in py3k-struni
Type: Stage:
Components: macOS Versions: Python 3.0
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: nnorwitz Nosy List: arsatiki, gvanrossum, nnorwitz
Priority: normal Keywords: patch

Created on 2007-08-07 05:19 by arsatiki, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
aetools.patch arsatiki, 2007-08-07 05:19
Messages (4)
msg52995 - (view) Author: Antti Rasinen (arsatiki) Date: 2007-08-07 05:19
The test failed because the imported aetools-module compared types directly instead of using isinstance. Fixed that and removed from types import * as well.

msg52996 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2007-08-07 05:42
Thanks!  I can't test this one right now, but it looks good.

Committed revision 56791.
msg52997 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2007-08-07 14:27
FYI, test passes.
msg52998 - (view) Author: Antti Rasinen (arsatiki) Date: 2007-08-07 17:49
I re-examined the code again. The comments clearly state that it should be a four-byte element. I changed the isinstance-test to isinstance(signature, bytes) and the test passes, again. I have a fear that the tests do not actually cover that part of code.
History
Date User Action Args
2022-04-11 14:56:25adminsetgithub: 45283
2008-01-06 22:29:45adminsetkeywords: - py3k
versions: + Python 3.0
2007-08-07 05:19:38arsatikicreate