➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix for failing test_plistlib in py3k-struni
Type: Stage:
Components: macOS Versions: Python 3.0
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: gvanrossum Nosy List: brotch, gvanrossum
Priority: normal Keywords: patch

Created on 2007-08-07 07:11 by brotch, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
plistlib-py3k-struni-fix.patch brotch, 2007-08-07 07:11
Messages (2)
msg52999 - (view) Author: brotchie (brotch) Date: 2007-08-07 07:11 
changes to plistlib.py:
- expat expects bytes so changed from using cStringIO to io.BytesIO
- renamed readPlistFromString, writePlistToString -> readPlistFromBytes, writePlistToBytes to reflect the change to BytesIO
- plistlib.Data now excepts and wraps a bytes object

changes to test_plistlib.py:
- transitioned To/FromString calls to To/FromBytes
- removed StringIO and cStringIO specific tests and replaced with an equivalent BytesIO test

test_plistlib.py now passes, tested on OSX Tiger 10.4.10.
msg53000 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2007-08-07 14:27 
Thanks!

Committed revision 56800.
History
Date User Action Args
2022-04-11 14:56:25adminsetgithub: 45285
2008-01-06 22:29:45adminsetkeywords: - py3k
versions: + Python 3.0
2007-08-07 07:11:51brotchcreate