This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Minor corrections to smtplib
Type: Stage:
Components: Library (Lib) Versions: Python 2.6
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: facundobatista Nosy List: alanmcintyre, facundobatista
Priority: normal Keywords: patch

Created on 2007-08-17 20:52 by alanmcintyre, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
smtplib-misc-fixes.diff alanmcintyre, 2007-08-17 20:52
smtplib-misc-fixes-2.diff alanmcintyre, 2007-08-21 22:09 Updated to include recently added smtplib tests
Messages (3)
msg53041 - (view) Author: Alan McIntyre (alanmcintyre) * (Python committer) Date: 2007-08-17 20:52
Two minor changes:

- In SMTP.send, there is a check for self.sock, which may  not exist if there has been no attempt to connect.  This patch adds a check for hasattr(self, 'sock') so that such an attempt to call send() will raise the more helpful SMTPServerDisconnected instead of an AttributeError.

- The docstring for SMTP.expn is a copy of that of the verify method.  This patch changes it to something more appropriate.
msg53042 - (view) Author: Alan McIntyre (alanmcintyre) * (Python committer) Date: 2007-08-21 22:09
The attached file smtplib-misc-fixes-2.diff includes a change to make test_smtplib.GeneralTests.testNotConnected pass when the original change for this patch is made.
File Added: smtplib-misc-fixes-2.diff
msg62721 - (view) Author: Facundo Batista (facundobatista) * (Python committer) Date: 2008-02-23 12:28
Applied in r60975. Thanks!
History
Date User Action Args
2022-04-11 14:56:26adminsetgithub: 45321
2008-02-23 12:28:34facundobatistasetstatus: open -> closed
resolution: accepted
messages: + msg62721
2007-08-17 20:52:46alanmcintyrecreate