This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: clean up trace.py
Type: Stage:
Components: Demos and Tools Versions: Python 2.3
process
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: skip.montanaro Nosy List: brett.cannon, loewis, mwh, skip.montanaro, zooko
Priority: normal Keywords: patch

Created on 2002-04-11 16:34 by zooko, last changed 2022-04-10 16:05 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
cdiff.patch.py zooko, 2002-04-11 16:34
cdiff.patch.py zooko, 2002-06-17 15:12
patch.py zooko, 2002-12-18 19:38
Messages (12)
msg39534 - (view) Author: Zooko O'Whielacronx (zooko) Date: 2002-04-11 16:34
moderately interesting changes:
 * bugfix: remove "feature" of ignoring files in the
tmpdir, as I was trying to run it on file in the tmpdir
and couldn't figure out why it gave no answer!  I think
the original motivation for that feature (spurious
"/tmp/" filenames for builtin functions??) has gone
away, but I'm not sure.
 * add more usage docs and warning about common mistake

pretty mundane changes:
 * remove unnecessary checks for backwards
compatibility with a version that never escaped from my
(Zooko's) laptop
 * add a future-compatible check: if the interpreter
offers an attribute called `sys.optimized', and it is
"true", and the user is trying to do something that
can't be done with an optimizing interpreter, then
error out
msg39535 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-04-14 10:27
Logged In: YES 
user_id=21627

Can you also provide the other cleanup that Guido requested
(change of license, removal of change logs, etc)?
msg39536 - (view) Author: Zooko O'Whielacronx (zooko) Date: 2002-06-17 14:57
Logged In: YES 
user_id=52562

I'll remove the change log and submit a patch momentarily. 
I'm afraid I cannot legally remove the copyright notice (or
more precisely: my removing the copyright notice from the
text would have no legal effect, and you can do it as well
as I can), since I am not Autonomous Zones Industries, Inc.

(AZI was my employer at the time I wrote and submitted that
patch.)

Regards,

Zooko
msg39537 - (view) Author: Zooko O'Whielacronx (zooko) Date: 2002-06-17 15:12
Logged In: YES 
user_id=52562

This patch removes the change log, as per GvR's request.
msg39538 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-10-07 21:21
Logged In: YES 
user_id=21627

Skip, what kind of processing do you plan for this patch?
msg39539 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-11-22 09:14
Logged In: YES 
user_id=21627

I have now applied file 25252 as trace.py 1.10.

Skip, what is your opinion on file 20995? It applies cleanly
and looks reasonable (even though I haven't tried to
understand it all).
msg39540 - (view) Author: Zooko O'Whielacronx (zooko) Date: 2002-11-22 14:14
Logged In: YES 
user_id=52562

Here are the changes in 20995:
 * bugfix: remove "feature" of ignoring files in the
tmpdir, as I was trying to run it on a file in the tmpdir
and couldn't figure out why it gave no answer! I think
the original motivation for that feature (spurious
"/tmp/" filenames for builtin functions??) has gone
away, but I'm not sure. 
 * add feature "--listfuncs" which prints out whether each
func was invoked or not, rather than how many times each
func was invoked
 * remove unnecessary checks for backwards
compatibility with a version that never escaped from my
(Zooko's) laptop
 * add doc about usage and about how it will silently fail
if invoked with -O
 * add a future-compatible check: if the interpreter
offers an attribute called `sys.optimized', and it is
"true", and the user is trying to do something that
can't be done with an optimizing interpreter, then
error out 
 * add some commented-out debug print statements
msg39541 - (view) Author: Michael Hudson (mwh) (Python committer) Date: 2002-11-22 14:21
Logged In: YES 
user_id=6656

I haven't looked at the patch, but:

>  * add doc about usage and about how it will silently fail
> if invoked with -O

This probably isn't true any more.  I hacked trace.py to use
co_lnotab when I removed SET_LINENO.

> * add a future-compatible check: if the interpreter
> offers an attribute called `sys.optimized', and it is
> "true", and the user is trying to do something that
> can't be done with an optimizing interpreter, then
> error out 

I want to shout "YAGNI!" for some reason...
msg39542 - (view) Author: Zooko O'Whielacronx (zooko) Date: 2002-12-18 19:38
Logged In: YES 
user_id=52562

I merged my patch to current HEAD (-r1.12) and removed a
bunch of it.

Important changes (from current HEAD):

 * don't ignore files in $TMPDIR
 * add "--list-funcs" mode to usage string

Minor changes (from current HEAD):

 * remove all code which was solely for backwards
compatibility with a version that nobody except me ever had.
 * I updated some inline docs to point to
sf.net/projects/pyutil instead of its ancestor
sf.net/projects/mojonation.

(Change from previous patch: I removed the part that mwh so
gleefully pointed out that I aint gonna need.)
msg39543 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2003-07-06 19:52
Logged In: YES 
user_id=357491

Is this patch still relevant now that trace.py has been put into Lib?
msg39544 - (view) Author: Zooko O'Whielacronx (zooko) Date: 2003-07-07 00:08
Logged In: YES 
user_id=52562

Tools/scripts/trace.py should be removed.  I'm going to
submit a couple of small cleanups to Lib/trace.py.

(I wasn't aware that trace.py had been moved to Lib until
recently.)
msg39545 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) Date: 2003-07-07 01:53
Logged In: YES 
user_id=44345

Zooko, I'm going to close this one.  A lot of water has passed
under the trace.py bridge since you first submitted it.  Let's
start afresh with a new patch. -Skip
History
Date User Action Args
2022-04-10 16:05:12adminsetgithub: 36413
2002-04-11 16:34:41zookocreate