This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: SocketServer behavior
Type: Stage:
Components: Library (Lib) Versions: Python 2.3
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: loewis Nosy List: loewis, mgilfix
Priority: normal Keywords: patch

Created on 2002-04-30 20:06 by mgilfix, last changed 2022-04-10 16:05 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
SocketServer.py.patch.2 mgilfix, 2002-06-03 16:46 2nd Version of the patch
Messages (5)
msg39786 - (view) Author: Michael Gilfix (mgilfix) Date: 2002-04-30 20:06
A bug, or lack of behavior in ServerSocket.py was
exposed while created a unit test for Python 2.3. As of
2.3, signals between threads propagate differently.
When cancelling a server that implemented threading
with a keyboard interrupt, the server would shut down
but not terminate (waiting on client threads).

The fit for this was to make the client threads
daemon-threads with the setDaemon call. Because this
was non-apparent, this patch adds a member variable
which acts as a hook and makes it clear that clients
need to either set or unset the variable when deriving
the class to control this behavior.

setDaemon is off by default, as this is thought to be
the consensus behavior.
msg39787 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-06-02 17:44
Logged In: YES 
user_id=21627

Could you please provide changes to the documentation as
well (i.e. Doc/lib/libsocksvr.tex, and Misc/NEWS)?

There is a typo: 'chanegs' -> 'changes'

There is no need to attach the modified source to the patch;
the context diff is enough.
msg39788 - (view) Author: Michael Gilfix (mgilfix) Date: 2002-06-03 16:45
Logged In: YES 
user_id=116038

All Address in the new patch. See SocketServer.py.patch.2.
msg39789 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-06-04 08:31
Logged In: YES 
user_id=21627

I recommend to approve this patch.
msg39790 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-11-22 08:09
Logged In: YES 
user_id=21627

Thanks for the patch. Applied as

libsocksvr.tex 1.16
SocketServer.py 1.33
NEWS 1.532

Sorry it took so long.
History
Date User Action Args
2022-04-10 16:05:17adminsetgithub: 36527
2002-04-30 20:06:31mgilfixcreate