Issue555929
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2002-05-14 13:22 by jlt63, last changed 2022-04-10 16:05 by admin. This issue is now closed.
Files | ||||
---|---|---|---|---|
File name | Uploaded | Description | Edit | |
AH_BOTTOM.patch | jlt63, 2002-05-14 13:22 | |||
AH_BOTTOM2.patch | jlt63, 2002-05-16 12:26 | version #2 |
Messages (10) | |||
---|---|---|---|
msg40026 - (view) | Author: Jason Tishler (jlt63) * | Date: 2002-05-14 13:22 | |
This patch complies with the following request found near the top of configure.in: # This is for stuff that absolutely must end up in pyconfig.h. # Please use pyport.h instead, if possible. I tested this patch under Cygwin, Win32, and Red Hat Linux. Python built and ran successfully on each of these platforms. |
|||
msg40027 - (view) | Author: Martin v. Löwis (loewis) * | Date: 2002-05-14 22:03 | |
Logged In: YES user_id=21627 Sounds good; please install this patch. |
|||
msg40028 - (view) | Author: Jason Tishler (jlt63) * | Date: 2002-05-15 11:55 | |
Logged In: YES user_id=86216 Committed as: configure 1.306 configure.in 1.316 pyconfig.h.in 1.34 Include/Python.h 2.47 Include/pyport.h 2.48 |
|||
msg40029 - (view) | Author: Martin v. Löwis (loewis) * | Date: 2002-05-15 18:25 | |
Logged In: YES user_id=21627 How did you test this patch? When I build Python on Linux, I get tons of error messages In file included from /usr/include/limits.h:152, from /usr/lib/gcc-lib/i486-suse-linux/2.95.3/include/limits.h:117, from /usr/lib/gcc-lib/i486-suse-linux/2.95.3/include/syslimits.h:7, from /usr/lib/gcc-lib/i486-suse-linux/2.95.3/include/limits.h:11, from Include/Python.h:28, from Python/frozenmain.c:4: /usr/include/bits/xopen_lim.h:123: warning: `LONG_BIT' redefined which come from pyport.h being included before limits.h. Backing the patch out; try again. |
|||
msg40030 - (view) | Author: Jason Tishler (jlt63) * | Date: 2002-05-15 19:24 | |
Logged In: YES user_id=86216 > How did you test this patch? I tested under Red Linux 7.1 configured with "--enable-shared". Note that my version of gcc is different than yours: $ gcc --version 2.96 > which come from pyport.h being included before limits.h. I was concerned about moving where pyport.h is included. I should have made this concern explicit. > Backing the patch out; No problem -- sorry for the trouble. > try again. Should I leave the #include "pyport.h" in its original location and move the DL_IMPORT stuff after it? Or, should I just try moving #include "pyport.h" to right after the #include <limits.h>? Since I can't reproduce the problem, I'm afraid that my next attempt may cause problems too. Would you be willing to retry my first patch and just move the #include "pyport.h" below the #include <limits.h>? |
|||
msg40031 - (view) | Author: Martin v. Löwis (loewis) * | Date: 2002-05-16 10:28 | |
Logged In: YES user_id=21627 Can you please explain why moving pyport.h is necessary? |
|||
msg40032 - (view) | Author: Jason Tishler (jlt63) * | Date: 2002-05-16 12:26 | |
Logged In: YES user_id=86216 > Can you please explain why moving pyport.h is necessary? It's not. It seemed cleaner, albeit riskier. Attached is the second version of my patch. It's identical to the first version except for the Include/Python.h hunk. The changes to Include/Python.h leave the #include "pyport.h" in its original location. Instead, I moved the DL_IMPORT stuff to after the #include "pyport.h". I tested under Cygwin, Win32, and Linux (i.e., gcc 2.96) again without any problems. Please test under your Linux environment. If successful, should we have others test on other platforms to prevent a repeat of this "fiasco?" |
|||
msg40033 - (view) | Author: Jason Tishler (jlt63) * | Date: 2002-05-22 16:27 | |
Logged In: YES user_id=86216 Any status Martin? Or, is it one strike and you're out? :,) Did you get a chance to try the latest patch under your Linux environment? |
|||
msg40034 - (view) | Author: Martin v. Löwis (loewis) * | Date: 2002-06-02 12:23 | |
Logged In: YES user_id=21627 The patch is fine now (tested on Linux and Windows/MSVC), please apply it. There is a convention on assigning patches: the patch should always be assigned to whoever needs to act on it next. So after uploading the revised patch, you should have assigned it back to me - that has the effect of the patch showing up in sf.net/my. |
|||
msg40035 - (view) | Author: Jason Tishler (jlt63) * | Date: 2002-06-04 15:14 | |
Logged In: YES user_id=86216 Committed as: configure 1.310 configure.in 1.320 pyconfig.h.in 1.37 Include/Python.h 2.50 Include/pyport.h 2.50 > There is a convention on assigning patches: the patch > should always be assigned to whoever needs to act > on it next. So after uploading the revised patch, > you should have assigned it back to me - that has > the effect of the patch showing up in sf.net/my. Ah! Sorry, I'll start thinking as developer instead of a patch submitter... |
History | |||
---|---|---|---|
Date | User | Action | Args |
2022-04-10 16:05:19 | admin | set | github: 36606 |
2002-05-14 13:22:04 | jlt63 | create |