This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: faqwiz.py could do email obfuscation
Type: enhancement Stage:
Components: Demos and Tools Versions:
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: gvanrossum Nosy List: gvanrossum, kiko_async
Priority: low Keywords:

Created on 2002-05-19 20:50 by kiko_async, last changed 2022-04-10 16:05 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
faqwiz-diff kiko_async, 2002-06-13 11:22 Patch to faqwiz 1.0.4 that rolls up some changes
Messages (5)
msg10859 - (view) Author: Christian Reis (kiko_async) Date: 2002-05-19 20:50
Faqwiz.py could obfuscate emails very easily, simply by
replacing @ by some other symbol in it's output. I've
homecooked a solution that basically involves:

adding to faqconf.py:

 # Obfuscate @ symbol as

 OBFUSCATE="-at-"

and changing interpolate() in faqwiz.py:

 def _interpolate(format, args, kw):
    try:
        quote = kw['_quote']
    except KeyError:
        quote = 1 
    d = (kw,) + args + (faqconf.__dict__,)
    m = MagicDict(d, quote)
    return string.replace(format % m, '@', OBFUSCATE)

This isn't my favourite solution, though, but since I
find the code a bit hard to follow, it suffices for
now. I'm willing to work a bit more on this if it
interests people.
msg10860 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2002-06-05 18:46
Logged In: YES 
user_id=6380

Good idea.
msg10861 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2002-06-10 20:45
Logged In: YES 
user_id=6380

Clearly this does too much -- interpolate is used in a
number of contexts where a @ shouldn't be obfuscated, e.g.
commands to be executed by the shell.

I'm unclear on *where* you'd like to obfuscate email
addresses. Do you only want to obfuscate the email address
of the person who modified the entry, or do you want to
obfuscate all @ signs anywhere in the text? The latter seems
overkill, and can cause breakage in code samples that happen
to use @ signs.

BTW, you're right that this code is hard to follow! It could
benefit from a few comments here or there... :-(
msg10862 - (view) Author: Christian Reis (kiko_async) Date: 2002-06-13 11:22
Logged In: YES 
user_id=222305

You're right, I did. The patch attached does it in a less
broken way, though I don't like the way I have to
permanently change last_changed_email - I just wanted to
obfuscate on the printing.

Anyway, since the link can't be a mailto anymore (which may
be considered a regression) I've removed the relevant link
from faqconf.py.

I've kept the faqconf.py OBFUSCATE symbol but am unsure as
to where it should go.

I've also rolled in two changes I did locally to my faqwiz.
The first one is a simple CSS mod that avoids the need for
an external image and makes the PRE sections highlight.

The second one is adding LABEL to the radiobuttons on the
front page and removing the "/"s and <BR> between the first
"query argument" options. It was confusing users at the
office. The LABEL tag allows you to click on the label and
have the radiobutton select, and is supported on superior
browsers (cough mozilla cough).

I'd appreciate comments, thanks.
msg10863 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2002-08-15 16:31
Logged In: YES 
user_id=6380

I'm rejecting this, not because i think it's a bad idea, but
because I have no time to maintain the faq wizard any more.

Christian Reis (the poster of this bug) has offered to take
over maintenance, but he won't use SourceForge. Christian,
if you ever get to this, would you mind at least adding a
URL to this SF bug report?
History
Date User Action Args
2022-04-10 16:05:20adminsetgithub: 36618
2002-05-19 20:50:27kiko_asynccreate