This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Remove support for Win16
Type: Stage:
Components: Windows Versions:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: loewis Nosy List: loewis, mhammond, nnorwitz, tim.peters
Priority: normal Keywords: patch

Created on 2002-06-16 20:32 by loewis, last changed 2022-04-10 16:05 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
win16.diff loewis, 2002-06-16 20:32
Messages (5)
msg40333 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-06-16 20:32
This patch removes support for WIN16 from Python, to 
allow simplification of some obfuscated code (in 
particular in posixmodule). According to PC/readme.txt, 
16-bit Windows is not supported anymore.

In addition to removing this code, it also streamlines the 
usage of the macros: MS_WINDOWS is now 
synonymous to MS_WIN32, and the patch replaces all 
occurrences of MS_WIN32 with MS_WINDOWS. The 
definition of MS_WIN32 is left alone, for backwards 
compatibility.
msg40334 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2002-06-27 02:29
Logged In: YES 
user_id=33168

I looked through the patch.  I didn't see any negative
effects on non-windows builds.
The change was almost always MS_WIN32 -> MS_WINDOWS.

I can't test the code though, since I don't have MS windows. :-)
Maybe we could remove all that useless windows code? :-)
Seriously, the patch seems fine and is probably a good idea,
but I can't really give any guidance, but the patch worked
fine on Linux.
msg40335 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2002-06-27 03:01
Logged In: YES 
user_id=31435

Mark, is this OK by you?  It's OK by me.
msg40336 - (view) Author: Mark Hammond (mhammond) * (Python committer) Date: 2002-06-27 08:03
Logged In: YES 
user_id=14198

Looks good to me!  Back to Martin to check in.
msg40337 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-06-30 15:30
Logged In: YES 
user_id=21627

Committed as

 _codecsmodule.c 2.12
_hotshot.c 1.19
_localemodule.c 2.33
mmapmodule.c 2.39
posixmodule.c 2.241
signalmodule.c 2.70
timemodule.c 2.128
fileobject.c 2.164
unicodeobject.c 2.155
PC/getpathp.c 1.27
PC/pyconfig.h 1.11
bltinmodule.c 2.261
dynload_win.c 2.11
errors.c 2.70
frozenmain.c 2.28
import.c 2.208
pythonrun.c 2.161
sysmodule.c 2.107
History
Date User Action Args
2022-04-10 16:05:25adminsetgithub: 36757
2002-06-16 20:32:25loewiscreate