This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Adds Galeon support to webbrowser.py
Type: Stage:
Components: Library (Lib) Versions: Python 2.3
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: nnorwitz Nosy List: loewis, nnorwitz, oracle
Priority: normal Keywords: patch

Created on 2002-07-24 13:27 by oracle, last changed 2022-04-10 16:05 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
webbrowser.py.patch oracle, 2002-07-24 13:27 Context Diff Patch
web.diff nnorwitz, 2002-10-09 23:35 patch #2, little cleanups
Messages (9)
msg40629 - (view) Author: Greg Copeland (oracle) Date: 2002-07-24 13:27
Simple context diff against current CVS tree to add
support for Galeon to webbrowser.py
msg40630 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-07-26 18:54
Logged In: YES 
user_id=21627

How does this relate to

https://sourceforge.net/tracker/index.php?func=detail&aid=586437&group_id=5470&atid=305470

?
msg40631 - (view) Author: Greg Copeland (oracle) Date: 2002-07-26 19:56
Logged In: YES 
user_id=40173

Not really sure.  I assume it's just a second patch by
another author.

What can I say, day late and a dollar short.  ;)

Having looked at the other patch, it appears mine is a
little more well rounded/complete/feature rich, if only
slightly.  I invite you to take a look for your self.  I'm
also not sure what version of webbrowser.py the other patch
is against.  My patch is against the CVS version so it will
be a breeze to apply.

Enjoy!
msg40632 - (view) Author: Greg Copeland (oracle) Date: 2002-08-12 18:12
Logged In: YES 
user_id=40173

Has then patch been accepted?  What's the standard why of
letting people know if a patch has been accepted or rejected?
msg40633 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-08-12 23:48
Logged In: YES 
user_id=21627

If the patch has been accepted, its Resolution will be set
to accepted, and SF will send you a message - so no, it
hasn't been accepted yet.

I still haven't found the time to compare the two patches,
and nobody else has presented any clear analysis of the
relative qualities, so I still don't know which one to
accept - apparently, nobody else has looked at them, either.
msg40634 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2002-10-09 23:35
Logged In: YES 
user_id=33168

Martin, I've closed the other (duplicate) patch.  I've
attached a new patch here with a few cleanups.  I manually
tested that this works with galeon.
msg40635 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-10-10 08:44
Logged In: YES 
user_id=21627

Neal, thanks for testing it. This is all this patch has been
waiting for, so please apply it.
msg40636 - (view) Author: Greg Copeland (oracle) Date: 2002-10-10 13:30
Logged In: YES 
user_id=40173

Ya thanks for cleaning it up.  After I submitted the patch,
I realized that I had left some print statements hanging around.
msg40637 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2002-10-10 22:50
Logged In: YES 
user_id=33168

Checked in as Lib/webbrowser.py 1.33
History
Date User Action Args
2022-04-10 16:05:31adminsetgithub: 36922
2002-07-24 13:27:49oraclecreate