This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: LDFLAGS support for build_ext.py
Type: Stage:
Components: Distutils Versions: Python 2.2
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: akuchling Nosy List: akuchling, chipsforbrains, loewis
Priority: normal Keywords: patch

Created on 2002-07-30 21:36 by chipsforbrains, last changed 2022-04-10 16:05 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
build_ext.py.patch chipsforbrains, 2002-07-30 21:36 a patch from one level below the source tree
sysconfig.patch chipsforbrains, 2002-08-06 19:35 A better patch for reading ENV info into the compiler commands
Messages (8)
msg40738 - (view) Author: Robert Weber (chipsforbrains) Date: 2002-07-30 21:36
a hack at best
msg40739 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-08-04 09:05
Logged In: YES 
user_id=21627

As a hack, I think it is unacceptable for Python.

I'd encourage you to integrate this (and CFLAGS) into
sysconfig.customize_compiler.

It would be ok if only the Unix compiler honors those
settings for now.
msg40740 - (view) Author: Robert Weber (chipsforbrains) Date: 2002-08-06 19:35
Logged In: YES 
user_id=245624

> As a hack, I think it is unacceptable for Python. 
> 
>I'd encourage you to integrate this (and CFLAGS) into 
>sysconfig.customize_compiler. 
> 
>It would be ok if only the Unix compiler honors those 
>settings for now. 
> Martin v. Löwis (loewis) 
 
I have written a better patch to sysconfig.py that doe all others so that everything works like autoconf. 
 
I will post the patch in a sec.s CFLAGS and
msg40741 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-08-07 08:27
Logged In: YES 
user_id=21627

The patch looks fine to me, but I'd like to hear the opinion
of a distutils guru.
msg40742 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2002-11-04 18:15
Logged In: YES 
user_id=11375

It mostly looks fine to me, too.  One question: the branch for CFLAGS
adds the value of CFLAGS to the shared linker invocation, which seems incorrect.  Why?  (And does autoconf also do this?  If autoconf does this,
it's probably for some reason and we should therefore also do it.)

msg40743 - (view) Author: Robert Weber (chipsforbrains) Date: 2002-11-04 18:33
Logged In: YES 
user_id=245624

I followed autoconf, where the linker includes CFLAGS, CPPFLAGS, and LDFLAGS.  I assume they had a good reason to do this.
msg40744 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2002-11-04 19:43
Logged In: YES 
user_id=11375

Really?  I suppose there might be platforms where this matters, like SGI with its -n32/-o32 switches for different binary formats.  

So, I have no objections to the patch; I'll check it in.

msg40745 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2002-11-04 19:53
Logged In: YES 
user_id=11375

Checked in as revision 1.87 of build_ext.py and revision 1.51
of sysconfig.py.  Thanks!

History
Date User Action Args
2022-04-10 16:05:32adminsetgithub: 36956
2002-07-30 21:36:10chipsforbrainscreate