This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: skips.txt for regrtest.py
Type: Stage:
Components: Tests Versions: Python 2.4
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: brett.cannon Nosy List: brett.cannon, loewis, nnorwitz, rhettinger
Priority: normal Keywords: patch

Created on 2002-12-24 20:03 by brett.cannon, last changed 2022-04-10 16:06 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
regrtest_skips.diff brett.cannon, 2003-10-14 01:51 newest diff w/ better output
Messages (11)
msg42065 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2002-12-24 20:03
As I promised on python-dev here is the functionality
to have  a skips.txt file for regrtest.py.  If the file
is present in the current directory it is parsed (using
the exact same code as used for  the -f option for
regrtest; good, old copy-n-paste) and all tests are
added to the expected skip set.

And as commented in the file, the name of the file is
so named after Skip Montanaro because he is too shy.
msg42066 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2002-12-26 18:10
Logged In: YES 
user_id=33168

There's no uploaded file!  You have to check the
checkbox labeled "Check to Upload & Attach File"
when you upload a file.

Please try again.

(This is a SourceForge annoyance that we can do
nothing about. :-( )
msg42067 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2002-12-26 21:04
Logged In: YES 
user_id=357491

Sorry about that!  I could have sworn I checked the box.  I
have uploaded enough files here you would think it would be
habitual by now.
msg42068 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2002-12-29 05:09
Logged In: YES 
user_id=80475

The patch looks good.
Now, it needs documentation.
msg42069 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2002-12-30 01:37
Logged In: YES 
user_id=357491

Oops.  =)

New diff includes a paragraph at the end of the module
documentation that mentions how to use the new functionality.

Please delete the old diff.
msg42070 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2003-03-30 21:15
Logged In: YES 
user_id=21627

Raymond, any further comments?
msg42071 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2003-04-23 18:33
Logged In: YES 
user_id=80475

It is time to exercise your new commit priviledges.
msg42072 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2003-04-23 22:27
Logged In: YES 
user_id=357491

=)  Sure thing.  Noticed it was assigned to me and everything.  Just need to 
add one feature; I want it to print out what tests were specifically skipped 
because of the skips.txt file so people don't forget that they have tests being 
skipped because of what they have in the file.
msg42073 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2003-05-09 00:46
Logged In: YES 
user_id=357491

OK, I am uploading a new patch but now it prints out if a test was not 
executed and then listed all the tests not executed.  This is for several 
reasons.  One is so you don't forget you have a skips.txt file and what tests 
are in it.  You also don't get any possible confusion on why the test was not 
listed while the tests are being executed or if it was printed that it was 
actually run and passed.

I also factored out the file parsing code used by the -f option to the function 
parsefile and use it for both -f and for parsing skips.txt .

Can someone please just take a quick look and tell me that the "not 
executed" statements are reasonable?  If someone gives me the all-clear I 
will apply the patch.
msg42074 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2003-10-14 01:51
Logged In: YES 
user_id=357491

Because I was getting slightly annoyed by having what tests were 
to be skipped printed every time a test is run, I changed it so that 
skips.txt is run only when you are executing the entire testing 
suite (i.e., not passing command-line arguments or not listing the 
tests in a file).
msg42075 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2004-03-21 22:30
Logged In: YES 
user_id=357491

I am rejecting this myself.  I personally have stopped using this patch 
(mainly because I don't feel the need to re-apply it after I lost my CVS 
checkout) and no one has ever used  it.  Having a test fail shouldn't be 
hidden, even if you expect the fail.
History
Date User Action Args
2022-04-10 16:06:03adminsetgithub: 37644
2002-12-24 20:03:46brett.cannoncreate