➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2003-02-20 12:36 by rwgk, last changed 2022-04-10 16:06 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| py23a2_irix_configure_make_log.txt | rwgk, 2003-02-20 12:39 | |||
| setup.diff | nnorwitz, 2003-02-23 21:59 | patch to catch all errors when building modules | ||
| iconv.diff | nnorwitz, 2003-02-28 02:58 | updated patch 2 | ||
| Messages (9) | |||
|---|---|---|---|
| msg14686 - (view) | Author: Ralf W. Grosse-Kunstleve (rwgk) | Date: 2003-02-20 12:36 | |
Using the latest Python 2.3a2 release ./configure; make fails on this platform: IRIX rattler 6.5 10120734 IP32 See attached logs. I've also tried configure --disable-ipv6, but the result is the same. The previous 2.3a1 release works without a problem on the exact same machine. |
|||
| msg14687 - (view) | Author: Neal Norwitz (nnorwitz) *  |
Date: 2003-02-20 23:14 | |
Logged In: YES
user_id=33168
In order to get the build to proceed, you can change line
210 of setup.py from:
except ImportError, why:
to:
except (ImportError, RuntimeError), why:
This is just before:
self.announce('*** WARNING: renaming "%s" since
importing it' ...)
|
|||
| msg14688 - (view) | Author: Neal Norwitz (nnorwitz) * |
Date: 2003-02-23 21:59 | |
Logged In: YES user_id=33168 Guido, I agree with your comment on python-dev that the fix below is not best. Attached is a patch which catches all exceptions, and changes the warning message appropriately. There are 2 other issues. 1) I don't know why the if 1: is there, should that be removed? 2) During a normal build these warning messages aren't printed, shouldn't they be? |
|||
| msg14689 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2003-02-23 23:52 | |
Logged In: YES user_id=6380 - I think the renaming shouldn't happen at all unless the exception is ImportError. - The if 1 can then be replaced by if isinstance(why, ImportError). - The message in the else branch should be changed to include the exception name. - I thought I fixed the logging level of these messages, by adding "level=3", in one of the first checkins after releasing 2.3a2. But possibly I may have botched that. Can you check that they really aren't printed? |
|||
| msg14690 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2003-02-24 01:30 | |
Logged In: YES user_id=6380 (Note, there are other compilation errors in the attached logs.) |
|||
| msg14691 - (view) | Author: Neal Norwitz (nnorwitz) * |
Date: 2003-02-28 02:58 | |
Logged In: YES user_id=33168 Updated patch for review (updated patch 2). Guido, can you review (it's short)? * renaming only happens on ImportError * if 1 is removed in favor of checking for ImportError * there was no problem with the warning being printed (level is in there), I must have been daydreaming. I reverted the change in iconv to again raise a RuntimeError instead of ImportError. The make will continue with the warning printed. This will hopefully get us over the worst problems with iconv. |
|||
| msg14692 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2003-02-28 14:06 | |
Logged In: YES user_id=6380 Yes, looks good. |
|||
| msg14693 - (view) | Author: Neal Norwitz (nnorwitz) * |
Date: 2003-02-28 17:34 | |
Logged In: YES user_id=33168 Checked in as: setup.py 1.152 Modules/_iconv_codec.c 1.14Misc/NEWS 1.681 |
|||
| msg14694 - (view) | Author: Neal Norwitz (nnorwitz) * |
Date: 2003-02-28 17:35 | |
Logged In: YES user_id=33168 Ralf, could you test from CVS to make sure everything is ok. The fix was general, but I'd like to make sure beta1 is in better shape. Thanks. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-10 16:06:56 | admin | set | github: 38012 |
| 2003-02-20 12:36:57 | rwgk | create | |