Issue701494
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2003-03-11 12:32 by tzot, last changed 2022-04-10 16:07 by admin. This issue is now closed.
Files | ||||
---|---|---|---|---|
File name | Uploaded | Description | Edit | |
apply_removal.diff | tzot, 2003-03-11 12:34 | diff -u of all files above | ||
apply_removal2.diff | doerwalter, 2003-03-20 15:26 | Remove distutils, logging, bsddb from patch, simplify | ||
apply3.diff | doerwalter, 2003-03-21 08:16 | Brett's patch: Remove test_builtin, minor changes |
Messages (11) | |||
---|---|---|---|
msg42991 - (view) | Author: Χρήστος Γεωργίου (Christos Georgiou) (tzot) * | Date: 2003-03-11 12:32 | |
More apply() removals from the following files: ./compiler/transformer.py ./curses/wrapper.py ./distutils/command/build_ext.py ./distutils/command/build_py.py ./distutils/archive_util.py ./distutils/dir_util.py ./distutils/filelist.py ./distutils/util.py ./bsddb/test/test_basics.py ./bsddb/test/test_dbobj.py ./bsddb/dbobj.py ./bsddb/dbshelve.py ./lib-tk/Canvas.py ./lib-tk/Dialog.py ./lib-tk/ScrolledText.py ./lib-tk/Tix.py ./lib-tk/Tkinter.py ./lib-tk/tkColorChooser.py ./lib-tk/tkCommonDialog.py ./lib-tk/tkFont.py ./lib-tk/tkMessageBox.py ./lib-tk/tkSimpleDialog.py ./lib-tk/turtle.py ./test/reperf.py ./test/test_b1.py ./test/test_builtin.py ./test/test_curses.py ./logging/__init__.py ./logging/config.py ./xml/dom/minidom.py ./plat-mac/Carbon/MediaDescr.py ./plat-mac/EasyDialogs.py ./plat-mac/FrameWork.py ./plat-mac/MiniAEFrame.py ./plat-mac/argvemulator.py ./plat-mac/icopen.py I know that the edited files are syntactically correct (ie compileall.compile_dir throws no errors), but please help testing that functionality is the same. I am testing at the moment for lib-tk changes. |
|||
msg42992 - (view) | Author: Walter Dörwald (doerwalter) * | Date: 2003-03-11 18:34 | |
Logged In: YES user_id=89016 There is no longer a test/test_b1.py in current CVS, so it seems you've done the diff against an older version. Could you update the patch for current CVS? Also according to PEP 291 (http://www.python.org/peps/pep-0291.html) both distutils and logging should remain 1.5.2 compatible. |
|||
msg42993 - (view) | Author: Raymond Hettinger (rhettinger) * | Date: 2003-03-12 01:41 | |
Logged In: YES user_id=80475 Also, be sure to read the PEP on which modules should not be modernized. Sometimes that information is written in the file itself rather than the pep. For instance, the logging package is supposed to be kept in a form that runs on older pythons. |
|||
msg42994 - (view) | Author: Χρήστος Γεωργίου (Christos Georgiou) (tzot) * | Date: 2003-03-12 08:46 | |
Logged In: YES user_id=539787 Walter: I untargzipped the python-latest.tgz of 2003-03-10 over an older directory (I think about a month ago), therefore the existence of test_b1.py. All files that exist in the current dist were also current. Raymond: you are correct about my not reading the file headers (it was a multifile vi session with a +/"apply(" option...) I just had a little time available for non-creative work, so I checked, saw that Guido already had changed most of the library files, and offered the change of the rest of them; you guys can do whatever you want with it :) The lib-tk changes seem to be ok, after running some UI python scripts I have. I haven't checked bsddb yet. |
|||
msg42995 - (view) | Author: Walter Dörwald (doerwalter) * | Date: 2003-03-20 15:26 | |
Logged In: YES user_id=89016 I've gone over the patch and simplyfied it a bit (e.g. replacing f(*(1,2,3) + args) with f(1,2,3, *args)). I've also removed the patches for distutils, logging and bsddb (code at the start of bsddb/dbutils.py seems to indicate that it should be usable with versions prior to 2.3). Raymond, do you have time to recheck the patch? |
|||
msg42996 - (view) | Author: Brett Cannon (brett.cannon) * | Date: 2003-03-21 02:49 | |
Logged In: YES user_id=357491 I went through Walter's diff by hand and found two places where more clean-up could be done and two show-stoppers. In case I don't get my version of the patch up fast enough for people, the files that have spots that could use some more minor clean-up are Lib/lib-tk/Tix.py and Lib/lib-tk/Tkinter.py . The showstoppers are in Lib/lib-tk/tkCommonDialog.py (method call that didn't get *'ed) and Lib/test/test_builtin.py (test_builtin.py should not even be patched since the affected lines are in the tests for apply() itself). I will have my version up before the weekend. |
|||
msg42997 - (view) | Author: Raymond Hettinger (rhettinger) * | Date: 2003-03-21 05:14 | |
Logged In: YES user_id=80475 Good job Brett :-) I'll wait for your next post before going through this one with a fine toothed comb. -- R |
|||
msg42998 - (view) | Author: Brett Cannon (brett.cannon) * | Date: 2003-03-21 07:42 | |
Logged In: YES user_id=357491 Well, I have now run into my first issue of not having commit priveleges; I can't upload my diff. So you will have to get it from http://www.ocf.berkeley.edu/~bac/apply3.diff . The only difference between my diff and Walter's is that I changed three files and removed the diff for test_builtin.py . |
|||
msg42999 - (view) | Author: Walter Dörwald (doerwalter) * | Date: 2003-03-21 08:16 | |
Logged In: YES user_id=89016 This shouldn't have anything to do with commit privileges. I'm uploading your apply3.diff so it doesn't get lost. If test_builtin calls apply it should probably make sure that both the PendingDeprecationWarning and the DeprecationWarning that might be issued some day are switched off. |
|||
msg43000 - (view) | Author: Brett Cannon (brett.cannon) * | Date: 2003-03-21 08:32 | |
Logged In: YES user_id=357491 Well, then SF is broken right now because I don't have an option to upload. As for the PendingDeprecationWarning check, I think that is a good idea. Shouldn't that be a separate patch, though? I personally can't do it any time soon because of PyCon plus I have updating test_urllib on my todo list (thanks, Raymond =). |
|||
msg43001 - (view) | Author: Raymond Hettinger (rhettinger) * | Date: 2003-04-06 09:20 | |
Logged In: YES user_id=80475 Re-reviewed files. Fixed one incomplete + (,args) in Tix.py. Added pending deprecation doc string to apply(). Marked approved and applied (no pun intended). |
History | |||
---|---|---|---|
Date | User | Action | Args |
2022-04-10 16:07:34 | admin | set | github: 38144 |
2003-03-11 12:32:59 | tzot | create |