This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: OpenVMS complementary patches
Type: Stage:
Components: Interpreter Core Versions: Python 2.3
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: loewis Nosy List: loewis, pieronne
Priority: normal Keywords: patch

Created on 2003-03-23 20:01 by pieronne, last changed 2022-04-10 16:07 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
diff pieronne, 2003-04-26 10:11 Correct formatted diff file
Messages (4)
msg43139 - (view) Author: Piéronne Jean-François (pieronne) Date: 2003-03-23 20:01
Explanations of the various patches:

fcntlmodule.c
Under VMS the third argument is declared as void *

expat.h
VMS C compiler can optionally mangle name longer 
than 31 characters, so it not necessary to change 
long name

fileobject.c
As the comment indicate this solve a problem into 
test_fileinput, but I don't understand why...

fpectlmodule.c
Enable SIGFPE handler

import.c
Support of VMS filesystem ODS-5

mmapmodule.c
VMS need a fsync before a call to fstat to return  
accurate information

myreadline.c
Use of vms__StdioReadline

posixmodule.c
I have move some initialisation part to a specific VMS 
file, so I have remove it form posixmodule.c

pyexpat.c
Convert VMS filename to a UNIX style filename.

socketmodule.c
This patch is the only one which is not delimited by
#ifdef __VMS
#endif
because IMHO it fix a bug into the original code


socketmodule.h
need to include socket.h and not sys/socket.h

sysmodule.c
Convert VMS filename to a UNIX style filename.


Regards,

Jean-François
msg43140 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2003-03-23 20:28
Logged In: YES 
user_id=21627

Can you please combine the patches into a single patch,
which can be applied using

patch -p0

??? You can use "diff -ur" or "cvs diff" to create a
recursive patch.
msg43141 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2003-03-23 23:11
Logged In: YES 
user_id=21627

Can you please explain the expat.h change? This is an
imported source, so I don't want to modify it unless there
is a really good reason.

The fileobject.c modification needs better analysis.
"corrects a test case problem" is not enough reason to make
such a change. Does the test case make assumptions that are
not supported by the relevant standards? Is there a bug in
VMS? etc.

msg43142 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2003-05-03 09:15
Logged In: YES 
user_id=21627

Thanks for the patch. Applied as

bz2module.c 1.19
fcntlmodule.c 2.39
fpectlmodule.c 2.19
grpmodule.c 2.21
mmapmodule.c 2.45
posixmodule.c 2.299
socketmodule.c 1.263
socketmodule.h 1.9
myreadline.c 2.29
dynload_shlib.c 2.15
sysmodule.c 2.118
History
Date User Action Args
2022-04-10 16:07:52adminsetgithub: 38206
2003-03-23 20:01:46pieronnecreate