This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fixes for 'commands' module on win32
Type: Stage:
Components: None Versions:
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: jlgijsbers, loewis, warnes
Priority: normal Keywords: patch

Created on 2003-04-01 17:51 by warnes, last changed 2022-04-10 16:08 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
commands.diff warnes, 2003-04-24 16:06 Revised patch in diff -u format
Messages (6)
msg43258 - (view) Author: Gregory Warnes (warnes) * Date: 2003-04-01 17:51
Currently the 'commands' module is provided with python
on Win32 systems, but does not function properly.  (The
library reference says it is only available on Unix).    

The commands module provides 3 functions:

       getoutput(cmd)              returns output
generated by executing 'cmd' in a shell
       getstatusoutput(cmd)     returns (status,output)
generated by executing 'cmd' in a shell
       getstatus(file)                returns output of
"ls -ld file"

Below is a simple patch which enables 'getoutput' and
'getstatusoutut' to work properly on Win32. Since
'getstatusfile' only makes sense on Unix, the patch
prevents it from being defined on Win32.  The current
behavior is maintained on all other platforms.



msg43259 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2003-04-08 06:02
Logged In: YES 
user_id=21627

Can you please resubmit this as a unified diff? Also, please
make sure you don't incude white-space only changes: Your
patch says that it changes all lines, just because you add a
CR at the end of every line (so either convert the modified
file to Unix conventions, or the original file to Windows
conventions).
msg43260 - (view) Author: Gregory Warnes (warnes) * Date: 2003-04-10 04:50
Logged In: YES 
user_id=9316

Uploaded a revised patch file, as requested.
msg43261 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2003-04-24 15:02
Logged In: YES 
user_id=21627

Apparently, you did not check the checkbox. Can you please 
retry?
msg43262 - (view) Author: Gregory Warnes (warnes) * Date: 2003-04-24 16:07
Logged In: YES 
user_id=9316

2nd attempt to upload fixed patch.
msg43263 - (view) Author: Johannes Gijsbers (jlgijsbers) * (Python triager) Date: 2004-08-15 13:14
Logged In: YES 
user_id=469548

The commands module is going to stay Unix-specific. There
are too many potential issues with trying to support the
various win32 command interpreters. See
http://mail.python.org/pipermail/python-dev/2004-August/047774.html
and its responses.
History
Date User Action Args
2022-04-10 16:08:00adminsetgithub: 38250
2003-04-01 17:51:14warnescreate